Skip to content

[gitpod-protocol] Add getGenericInvite to golang client #14273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 31, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Oct 30, 2022

Description

Adds support for getGenericInvite in the Go client for gitpod-protocol (server)

A couple of drive-by fixes to define (and use) function names as per existing pattern.

Related Issue(s)

Fixes #

How to test

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

@easyCZ easyCZ requested a review from a team October 30, 2022 20:21
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Oct 30, 2022
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold for question

@easyCZ
Copy link
Member Author

easyCZ commented Oct 31, 2022

/werft run

👍 started the job as gitpod-build-mp-gitpod-proto-get-generic-invite.1
(with .werft/ from main)

@easyCZ easyCZ force-pushed the mp/gitpod-proto-get-generic-invite branch from 92dd887 to 967369a Compare October 31, 2022 14:24
@easyCZ
Copy link
Member Author

easyCZ commented Oct 31, 2022

/unhold

@roboquat roboquat merged commit 355bd42 into main Oct 31, 2022
@roboquat roboquat deleted the mp/gitpod-proto-get-generic-invite branch October 31, 2022 15:09
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants