Skip to content

[image-builder] Increment metric on build completions #14565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Increment the gitpod_image_builder_builds_done_total counter when the image builder completes a build.

This metric was already configured and registered but never used.

Related Issue(s)

Part of #12960

How to test

  • Port forward to the image builder in the preview environment (kubectl port-forward svc/gitpod-image-builder-mk3 9500:9500)
  • Hit the metrics endpoint (:9500/metrics).
  • Trigger an image build.
  • See the gitpod_image_builder_builds_done_total counter increase on completion, with the appropriate label on success or failure.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide

Increment the counter when a build completes.
@andrew-farries andrew-farries requested a review from a team November 9, 2022 16:03
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-image-build-completion-metric.2 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Nov 9, 2022
@roboquat roboquat merged commit 7d37efe into main Nov 9, 2022
@roboquat roboquat deleted the af/image-build-completion-metric branch November 9, 2022 18:53
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants