[JetBains] Fix to continuously observe ports while Gitpod Port Forwarding Service is active #14628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
felladrin
changed the title
|
Reviewing this now 👀 🤩 |
andreafalzetti
approved these changes
Nov 11, 2022
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #14408 I forgot to add the loop which restarts the observation on Ports from the Supervisor in case of an exception in the Supervisor (e.g. momentaneous connection loss). This PR fixes it. Besides that, it now uses a coroutine instead of a thread for it.
Related Issue(s)
How to test
I'm unsure about how it can be tested. It would need to have an error or disconnection from Supervisor's side.
But you can verify that ports are being forwarded automatically and are being displayed in the Ports View. It shows the service continues working as expected.
Release Notes
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh