-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update base image and leeway #14631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update base image and leeway #14631
Conversation
Update base image and leeway
started the job as gitpod-build-aledbf-leeway.1 because the annotations in the pull request description changed |
Update images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for upgrading Leeway and the base image! The Leeway version bump comes with breaking changes. CI won't catch it right now due to job protection (see issue) so you'll have to start a job manually using
werft job run github
I did that here and it fails before it even gets to the build as there is apparently a breaking change made to previewctl
here - our image was never rebuilt and updated after that change it seems previewctl
in the docker image to avoid hickups like this in the future.
If you want to try to fix all the breaking changes in this PR then:
- For the leeway breaking change It should be enough just to remove
--dont-retag
everywhere. - For
previewctl
all--kube-save-path
has to be replaced with invocations whereKUBECONFIG
is set instead.
If you'd rather not deal with this mess I understand and I can take care of it, but I won't have time until Monday.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Works like a charm. Tested in-workspace using leeway run dev/preview:build
and Werft job using werft job run github
here.
I left one comment, but it doesn't block merge so approving 🚀
3707cbf
to
2885b56
Compare
|
Related Issue(s)
Required for: #14524
Release Notes
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh