Skip to content

Update base image and leeway #14631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 12, 2022
Merged

Update base image and leeway #14631

merged 4 commits into from
Nov 12, 2022

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 11, 2022

Related Issue(s)

Required for: #14524

Release Notes

NONE

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

Update base image and leeway
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-leeway.1 because the annotations in the pull request description changed
(with .werft/ from main)

Update images
@roboquat roboquat added size/M and removed size/XS labels Nov 11, 2022
@aledbf aledbf marked this pull request as ready for review November 11, 2022 20:09
@aledbf aledbf requested review from a team November 11, 2022 20:09
@github-actions github-actions bot added team: SID team: devx team: IDE team: workspace Issue belongs to the Workspace team labels Nov 11, 2022
@aledbf aledbf mentioned this pull request Nov 11, 2022
4 tasks
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for upgrading Leeway and the base image! The Leeway version bump comes with breaking changes. CI won't catch it right now due to job protection (see issue) so you'll have to start a job manually using

werft job run github

I did that here and it fails before it even gets to the build as there is apparently a breaking change made to previewctl here - our image was never rebuilt and updated after that change it seems ☹️ We have an issue to not include previewctl in the docker image to avoid hickups like this in the future.

If you want to try to fix all the breaking changes in this PR then:

  1. For the leeway breaking change It should be enough just to remove --dont-retag everywhere.
  2. For previewctl all --kube-save-path has to be replaced with invocations where KUBECONFIG is set instead.

If you'd rather not deal with this mess I understand and I can take care of it, but I won't have time until Monday.

@aledbf aledbf requested a review from mads-hartmann November 11, 2022 20:47
Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Works like a charm. Tested in-workspace using leeway run dev/preview:build and Werft job using werft job run github here.

I left one comment, but it doesn't block merge so approving 🚀

@github-actions
Copy link
Contributor

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@roboquat roboquat merged commit 4bdf65c into main Nov 12, 2022
@roboquat roboquat deleted the aledbf/leeway branch November 12, 2022 09:37
@roboquat roboquat added the deployed: IDE IDE change is running in production label Nov 14, 2022
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/M team: devx team: IDE team: SID team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants