[usage] Deploy usage by default #14668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
force-pushed
the
mp/usage-deploy-default
branch
3 times, most recently
from
fdeb2cb to
867f683
Compare
github-actions
bot
added
team: SID
team: devx
team: webapp
vulkoingim
approved these changes
Nov 15, 2022
easyCZ
force-pushed
the
mp/usage-deploy-default
branch
from
867f683 to
ba59c1b
Compare
andrew-farries
approved these changes
Nov 16, 2022
| // This is the default configuration, used in self-hosted installs. | ||
| // For SaaS, we explicitly configure it based on workspace classes below. | ||
| CreditsPerMinuteByWorkspaceClass: map[string]float64{ | ||
| "default": 0.1666666667, |
There was a problem hiding this comment.
Is the credits value significant? If not, adding a comment to that effect might be worthwhile.
There was a problem hiding this comment.
It is significant. At least the default class has to be defined. We could define it with a value of 0, but that risks actually making a mistake and not charging for instances at all in our SaaS..
|
There is also this comment in the linked issue which suggests we should also remove a |
Updated linked issues to say "relates to" rather than "fixes" |
ArthurSens
approved these changes
Nov 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will deploy the usage component by default in all installations.
It uses the following defaults:
Usage Ledger schedule - 15m
Reset Usage schedule - 15m
WorkspaceClass Credit cost - default: 0.1666666667
No Stripe API Key, No Stripe prices
Related Issue(s)
Related to #14129
How to test
Usage component is deployed in preview
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh