Skip to content

[public api] Use personal access tokens feature flag in Tokens Service #14685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Nov 15, 2022

Description

  • Makes feature flag available to the Tokens Service
  • Use it in CreatePersonalAccessToken RPC

Related Issue(s)

Relates #14602

How to test

Unit tests:
In /components/public-api-server/pkg/apiv1 run go test .
Note: This test currently tests the path where someone is not feature-flagged.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@laushinka laushinka force-pushed the lau/ff-configcat-config branch from 9534def to 93ecf87 Compare November 15, 2022 12:19
@laushinka laushinka marked this pull request as ready for review November 15, 2022 12:26
@laushinka laushinka requested review from a team November 15, 2022 12:26
@github-actions github-actions bot added team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team labels Nov 15, 2022
Copy link
Member

@easyCZ easyCZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'm adding some helper support for experiments in tests so we can then extend this to use it.

@roboquat roboquat merged commit 98e6fe7 into main Nov 15, 2022
@roboquat roboquat deleted the lau/ff-configcat-config branch November 15, 2022 12:36
@roboquat roboquat added the deployed: webapp Meta team change is running in production label Nov 16, 2022
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants