Skip to content

[public-api] Initial stub implemention for CreateToken #14713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 16, 2022
Merged

[public-api] Initial stub implemention for CreateToken #14713

merged 1 commit into from
Nov 16, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Nov 15, 2022

Description

  • Creates a stub implementation for CreateToken RPC
  • Ensures that only users with enabled feature flag can access the RPC
  • Slight refactor to reduce duplication

Related Issue(s)

How to test

Unit tests

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@easyCZ easyCZ force-pushed the mp/papi-tokens-get-token-stub branch 4 times, most recently from 0cb0729 to 7311a06 Compare November 15, 2022 15:40
@roboquat roboquat added size/L and removed size/M labels Nov 15, 2022
@easyCZ easyCZ force-pushed the mp/papi-tokens-get-token-stub branch from 7311a06 to c1316bb Compare November 15, 2022 20:30
@easyCZ easyCZ marked this pull request as ready for review November 15, 2022 20:31
@easyCZ easyCZ requested a review from a team November 15, 2022 20:31
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 15, 2022
@easyCZ easyCZ mentioned this pull request Nov 15, 2022
Merged
4 tasks
@roboquat roboquat merged commit d3eb25c into main Nov 16, 2022
@roboquat roboquat deleted the mp/papi-tokens-get-token-stub branch November 16, 2022 08:56
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/L team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @andrew-farries @roboquat