Skip to content

Add retry option to install-context #14793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 24, 2022
Merged

Conversation

mads-hartmann
Copy link
Contributor

@mads-hartmann mads-hartmann commented Nov 18, 2022

Description

Adds a --retry <count> flag to previewctl install-context and uses it in leeway run dev:preview.

Also fixed one bug when using leeway run dev/preview/previewctl:install multiple times.

Related Issue(s)

Fixes #14759

How to test

leeway run dev:preview

Release Notes

NONE

Documentation

N/A

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@mads-hartmann mads-hartmann force-pushed the mads/add-retry-to-previewctl branch from b542cd9 to 364718c Compare November 23, 2022 10:28
@mads-hartmann mads-hartmann marked this pull request as ready for review November 23, 2022 10:30
@mads-hartmann mads-hartmann requested a review from a team November 23, 2022 10:30
Copy link
Member

@meysholdt meysholdt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@roboquat roboquat merged commit 3f040eb into main Nov 24, 2022
@roboquat roboquat deleted the mads/add-retry-to-previewctl branch November 24, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dev:preview] Add retry to previewctl install-context invocation
3 participants