Skip to content

[proxy] Extract common request matchers to a snippet #15079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

andrew-farries
Copy link
Contributor

Description

Extract some request matchers that are duplicated between different handle blocks into a snippet.

Related Issue(s)

Part of #9198

How to test

Existing behaviour with request to pre-flights based on the slow_database feature flag is preserved.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-slow-database
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-af-extract-request-matchers.4 because the annotations in the pull request description changed
(with .werft/ from main)

@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Nov 30, 2022
Copy link
Member

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from af/add-latency-to-auth-endpoints to main December 1, 2022 14:43
@andrew-farries andrew-farries force-pushed the af/extract-request-matchers branch from ae04eb8 to e1c4d5f Compare December 1, 2022 14:43
@roboquat roboquat merged commit fc3fcf3 into main Dec 1, 2022
@roboquat roboquat deleted the af/extract-request-matchers branch December 1, 2022 14:53
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants