Skip to content

Update spacing in token regeneration modal #15107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2022
Merged

Update spacing in token regeneration modal #15107

merged 1 commit into from
Dec 1, 2022

Conversation

gtsiolis
Copy link
Contributor

@gtsiolis gtsiolis commented Dec 1, 2022 •
edited
Loading

Description

This will update spacing between elements in the token regeneration modal, following the proposal in #15104 (comment).

Related Issue(s)

Fixes #15104

How to test

  1. Create a new access token
  2. Go to the access tokens list
  3. Click on more actions to regenerate a token or regenerate via the token edit page
  4. Notice the spacing in the modal

From #15104 (comment):

BEFORE AFTER
modal-before modal-after

Release Notes

Update spacing in token regeneration modal

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@gtsiolis gtsiolis requested a review from a team December 1, 2022 14:01
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 1, 2022
@gtsiolis gtsiolis mentioned this pull request Dec 1, 2022
Closed
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-gt-reduce-token-regeneration-modal-density.1 because the annotations in the pull request description changed
(with .werft/ from main)

@easyCZ
Copy link
Member

easyCZ commented Dec 1, 2022

Screenshot 2022-12-01 at 15 22 51

Spacing increased.

@roboquat roboquat merged commit d0a63ed into main Dec 1, 2022
@roboquat roboquat deleted the gt/reduce-token-regeneration-modal-density branch December 1, 2022 14:24
@gtsiolis
Copy link
Contributor Author

gtsiolis commented Dec 1, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks, @easyCZ! 🍟 🍟

@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easyCZ easyCZ easyCZ approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce Regenerate Token UI density
3 participants
@gtsiolis @easyCZ @roboquat