Skip to content

[pat] Extract into separate files #15158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 5, 2022
Merged

[pat] Extract into separate files #15158

merged 1 commit into from
Dec 5, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Dec 5, 2022

Description

PersonalAccessTokens.tsx became a bit long and difficult to navigate/read for debugging or future improvements.
This PR extracts out:

  • PersonalAccessTokensCreateView: it's not rendered at all by PersonalAccessTokens and can live on its own.
  • TokenEntry: the detail row of each token
  • ShowTokenModal
  • DateSelector

Related Issue(s)

How to test

Everything should still work. Preview env

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@laushinka laushinka changed the title [pat] Extract into components [pat] Extract into separate files Dec 5, 2022
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-lau-list-15098.3 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka laushinka marked this pull request as ready for review December 5, 2022 13:21
@laushinka laushinka requested a review from a team December 5, 2022 13:21
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 5, 2022
const [token, setToken] = useState<EditPATData>({
name: "",
expirationDays: "30",
expirationDate: new Date(Date.now() + 30 * 24 * 60 * 60 * 1000),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, this would be computed at the point of the request, not at the point of the view create

@roboquat roboquat merged commit 94552cd into main Dec 5, 2022
@roboquat roboquat deleted the lau/list-15098 branch December 5, 2022 14:00
@laushinka laushinka mentioned this pull request Dec 5, 2022
4 tasks
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XXL team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants