[usage] increment cycle on finalize invoice #15172
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
sefftinge/ubp-when-receiving-a-14992
branch
from
7274068 to
20828a7
Compare
easyCZ
reviewed
Dec 6, 2022
|
|
||
| _, err = s.ccManager.IncrementBillingCycle(ctx, usage.AttributionID) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
This potentially leaks a DB error to the API. You should be catching the error and using status.Errorf(codes.NotFound, "Failed to get invoice with ID %s: %s", in.GetInvoiceId(), err.Error()) report an appropriate API facing error + code
| } | ||
| err = c.conn.Save(&newCostCenter).Error | ||
| if err != nil { | ||
| return CostCenter{}, err |
There was a problem hiding this comment.
Suggested change
| return CostCenter{}, err | |
| return CostCenter{}, fmt.Errorf("failed to store cost center ID: %s", err) |
otherwise you don't actually know what failed
svenefftinge
force-pushed
the
sefftinge/ubp-when-receiving-a-14992
branch
from
20828a7 to
524870c
Compare
easyCZ
approved these changes
Dec 6, 2022
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Increment the billing cycle on after finalize invoice webhook.
Related Issue(s)
Fixes #14992
How to test
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh