Skip to content

[pat] Paginate list tokens view #15180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022
Merged

[pat] Paginate list tokens view #15180

merged 1 commit into from
Dec 6, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Dec 6, 2022

Description

Pagination with 50 entries per page.

Screenshot 2022-12-06 at 12 46 24

Screenshot 2022-12-06 at 12 46 31

Related Issue(s)

Fixes #15098

How to test

Preview env
Pagination is a bit cumbersome to test.

  1. Change this to a low number (e.g. 2).
  2. Run yarn telepresence in components/dashboard.
  3. See the pagination.

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-lau-list-paginate-15098.3 because the annotations in the pull request description changed
(with .werft/ from main)

@laushinka laushinka force-pushed the lau/list-paginate-15098 branch 2 times, most recently from b7a3895 to 1e12cca Compare December 6, 2022 11:31
@laushinka laushinka force-pushed the lau/list-paginate-15098 branch from 1e12cca to 20b06ef Compare December 6, 2022 11:49
@laushinka laushinka marked this pull request as ready for review December 6, 2022 11:55
@laushinka laushinka requested a review from a team December 6, 2022 11:55
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Dec 6, 2022
@easyCZ
Copy link
Member

easyCZ commented Dec 6, 2022

Shall we default to 25? The list gets quite long with 50 entries

Screenshot 2022-12-06 at 13 55 28

@easyCZ
Copy link
Member

easyCZ commented Dec 6, 2022

Nice, works as expected.

@easyCZ
Copy link
Member

easyCZ commented Dec 6, 2022

/hold for discussion on default page size

@laushinka
Copy link
Contributor Author

laushinka commented Dec 6, 2022

Shall we default to 25? The list gets quite long with 50 entries

That is quite long 😅 Sure!

@laushinka laushinka force-pushed the lau/list-paginate-15098 branch from 20b06ef to 4d3a69c Compare December 6, 2022 13:35
@roboquat roboquat merged commit 7697936 into main Dec 6, 2022
@roboquat roboquat deleted the lau/list-paginate-15098 branch December 6, 2022 13:53
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List all (or paginate) access tokens view
3 participants