Skip to content

allow to layout multiple JB product layers in the same image #15182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Dec 6, 2022

Description

This PR changes the file structure for JetBrains IDE images. The previous structure would allow only a single IDE to be stored, with the new approach we can layer multiple IDEs without risk of overriding each other.

Related Issue(s)

Related to #6740

How to test

  1. For stable, start a workspace for a couple of JB IDE and make sure they work as expected, including customizations done via the backend-plugin to the Backend Control Center, or custom actions are visible, meaning the plugin is loaded correctly.
  2. For latest, TODO

Release Notes

NONE

Documentation

Werft options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-ide-jb-image-layout.2 because the annotations in the pull request description changed
(with .werft/ from main)

@andreafalzetti
Copy link
Contributor

andreafalzetti commented Dec 6, 2022

/werft run

👍 started the job as gitpod-build-ide-jb-image-layout.4
(with .werft/ from main)

@andreafalzetti
Copy link
Contributor

the backend-plugin does not get loaded correctly, I am trying to understand why

Copy link
Contributor

@iQQBot iQQBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felladrin felladrin force-pushed the ide/jb-image-layout branch 6 times, most recently from 17e6e98 to 008a182 Compare December 7, 2022 14:17
Co-authored-by: Victor Nogueira <[email protected]>
Co-authored-by: Anton Kosyakov <[email protected]>
@felladrin felladrin force-pushed the ide/jb-image-layout branch from 008a182 to c13efc8 Compare December 7, 2022 14:20
@felladrin felladrin marked this pull request as ready for review December 7, 2022 14:48
@felladrin felladrin requested a review from a team December 7, 2022 14:48
@roboquat roboquat merged commit 0a34a26 into main Dec 7, 2022
@roboquat roboquat deleted the ide/jb-image-layout branch December 7, 2022 14:49
@roboquat roboquat added deployed: IDE IDE change is running in production deployed Change is completely running in production labels Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: IDE IDE change is running in production deployed Change is completely running in production editor: jetbrains release-note-none size/XL team: IDE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants