[jetbrains launcher] introduce backward compatible warmup command #15243
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-ide-jb-warmup-logic-status.2 because the annotations in the pull request description changed |
|
@andreafalzetti Should not we squash and add co-authors? |
akosyakov
approved these changes
Dec 8, 2022
andreafalzetti
commented
Dec 8, 2022
| var warmup bool | ||
|
|
||
| if len(os.Args) < 2 { | ||
| log.Fatalf("Usage: %s (warmup|<port>)\n", os.Args[0]) |
There was a problem hiding this comment.
I think warmup is the first arg here
felladrin
reviewed
Dec 8, 2022
Co-authored-by: Victor Nogueira <[email protected]> Co-authored-by: Anton Kosyakov <[email protected]>
andreafalzetti
force-pushed
the
ide/jb-warmup-logic-status
branch
from
98a48ea to
b702f97
Compare
|
thanks for the reviews 🙏 I've tested and address the comments, so I will unhold :) /unhold |
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introducing a
warmupcmd instatuscomponent (in the futrue it'll be renamed tojetbrains-launcher) as a first step to land this PR: #15233 with the end goal of moving the warmup logic in the jetbrains component instead of being inserveroride-service.Related Issue(s)
Relates to #6740
How to test
Already tested but if want to double check:
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh