Use workspaceStatus stream rpc in supervisor #15403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
started the job as gitpod-build-hw-pub-stream.3 because the annotations in the pull request description changed |
9 tasks
jeanp413
force-pushed
the
hw/pub-stream
branch
2 times, most recently
from
f6fd8d7 to
4ba5e33
Compare
jeanp413
force-pushed
the
hw/pub-stream
branch
from
b5953ca to
ae0c017
Compare
jeanp413
requested review from
csweichel,
akosyakov and
easyCZ
as code owners
|
/hold |
github-actions
bot
added
team: SID
team: IDE
team: webapp
jeanp413
approved these changes
Jan 10, 2023
mustard-mh
removed
team: webapp
easyCZ
reviewed
Jan 10, 2023
Comment on lines
+406
to
+418
| if port.Policy == v1.PortPolicy_PORT_POLICY_PUBLIC { | ||
| info.Visibility = gitpod.PortVisibilityPublic | ||
| } else { | ||
| info.Visibility = gitpod.PortVisibilityPrivate | ||
| } |
There was a problem hiding this comment.
PortPolicy is one of 3 values:
PortPolicy_PORT_POLICY_UNSPECIFIED PortPolicy = 0
// Private means the port is accessible by the workspace owner only using the workspace port URL
PortPolicy_PORT_POLICY_PRIVATE PortPolicy = 1
// Public means the port is accessible by everybody using the workspace port URL
PortPolicy_PORT_POLICY_PUBLIC PortPolicy = 2
Use a switch here and handle them all. This ensures that you actually detect cases where the port policy is not set (UNSPECIFIED)
There was a problem hiding this comment.
It's the same as here, it can only be public or private and if for some reason is unspecified it should convert to private either way 🤔
gitpod/components/supervisor/pkg/serverapi/publicapi.go
Lines 406 to 410 in 6245c32
mustard-mh
force-pushed
the
hw/pub-stream
branch
from
4f512f0 to
6245c32
Compare
jeanp413
force-pushed
the
hw/pub-stream
branch
from
2ee4c99 to
c4900d8
Compare
mustard-mh
force-pushed
the
hw/pub-stream
branch
2 times, most recently
from
f98130f to
829f1ea
Compare
Co-authored-by: mustard <[email protected]> Co-authored-by: Jean Pierre <[email protected]>
mustard-mh
force-pushed
the
hw/pub-stream
branch
from
829f1ea to
77ed9d5
Compare
|
Test with
|
|
/unhold |
|
/werft run 👍 started the job as gitpod-build-hw-pub-stream.19 |
roboquat
added
deployed: IDE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use workspaceStatus stream rpc in supervisor
Requires #15451
Related #15383
How to test
Open a workspace and check port view updates successfully when changing port state to public/private
Release Notes
Documentation
Werft options:
If enabled this will build
install/previewValid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh