✨ standardize gp CLI timeout cmds output #16091
Conversation
|
started the job as gitpod-build-siddhant-k-code-gitpod-cli-flexible-15945.1 because the annotations in the pull request description changed |
...nd-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/actions/ExtendWorkspaceTimeoutAction.kt
Outdated
Show resolved
Hide resolved
...nd-plugin/src/main/kotlin/io/gitpod/jetbrains/remote/actions/ExtendWorkspaceTimeoutAction.kt
Outdated
Show resolved
Hide resolved
| @@ -31,10 +31,10 @@ class ExtendWorkspaceTimeoutAction : AnAction() { | |||
| thisLogger().error("gitpod: failed to extend workspace timeout", e) | |||
There was a problem hiding this comment.
Thought: Interesting, I didn't realise this logic was copied into our JetBrains codebase, I assumed it was running the gp command under the hood.
| @@ -31,10 +31,10 @@ class ExtendWorkspaceTimeoutAction : AnAction() { | |||
| thisLogger().error("gitpod: failed to extend workspace timeout", e) | |||
| } else { | |||
| if (result.resetTimeoutOnWorkspaces.isNotEmpty()) { | |||
| message = "Workspace timeout has been extended to three hours. This reset the workspace timeout for other workspaces." | |||
| message = "Workspace timeout is extended to 180 minutes. This reset the workspace timeout for other workspaces." | |||
There was a problem hiding this comment.
This reset the workspace timeout for other workspaces.
Is this still true? I assume workspace timeouts do not still apply just to one workspace still, do they?
This output also differs from the gp CLI output, we should keep them inline (even if it's a different codebase).
This will need documenting in the timeouts documentation update.
There was a problem hiding this comment.
There was a problem hiding this comment.
I will keep this wording change as it is. And regarding the Reset workspace timeout message. We can followup on this issue: #16107
|
Thanks for the update @Siddhant-K-code ! :) I've requested Sven's approval, as a courtesy as he was involved in the original change, and might have thoughts. I won't personally approve as I don't think that's my place, will leave for other engineers. However, I've left my thoughts and comments 🙏 |
Siddhant-K-code
force-pushed
the
siddhant-k-code/gitpod-cli-flexible-15945
branch
from
2fd0745 to
293837f
Compare
|
Thanks, @loujaybee. I've updated the PR with the suggested changes & a comment (#16091 (comment)). It's ready for review & |
|
@loujaybee code wise looks alright, if messaging works for you please approve 🙏 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Siddhant-K-code
deleted the
siddhant-k-code/gitpod-cli-flexible-15945
branch
Description
Standardize the Gitpod CLI output in
timeoutcommands. Also changes the JetBrains Plugin Message popup 😄Related Issue(s)
Fixes #16084, #15945
How to test
Open Preview
Open any Workspace
Run the following commands:
gp timeout set 30m gp timeout extend gp timeout show& Read through the outputs 👀
Release Notes
Documentation
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPreview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh