Use the actual current period on the usage page #16474
Conversation
|
annotations in the pull request changed, but user is not allowed to start a job |
gtsiolis
added
community-contribution
do-not-merge/cla-pending
|
/werft run with-preview=true 👍 started the job as gitpod-build-patch-1-fork.11 |
|
/werft run with-clean-slate-deployment=true with-preview=true recreate-vm=true 👍 started the job as gitpod-build-patch-1-fork.12 |
|
started the job as gitpod-build-patch-1.4 because the annotations in the pull request description changed |
There was a problem hiding this comment.
Thanks for contributing, @bonysureliya! 🍊
I've updated the PR description to link back to the relevant issue and include the deleted release notes section.
I couldn't test this in the preview environment as the build was failing[1]:
Failed to compile.
src/components/UsageView.tsx
Syntax error: 'finally' expected (57:8)
- Could you fix this—I'll retrigger the build once you push some changes.
- You'll also need to sign a CLA[1] once before merging your first contribution. Cc @meysholdt
gtsiolis
force-pushed
the
patch-1
branch
2 times, most recently
from
4a6f82b to
bf9efa4
Compare
|
@bonysureliya Friendly reminder from #16474 (review):
|
|
/werft run with-preview 👍 started the job as gitpod-build-patch-1-fork.13 |
|
Thank you, @bonysureliya, for signing our CLA! |
|
/werft run with-preview 👍 started the job as gitpod-build-patch-1-fork.14 |
gtsiolis
changed the title
gtsiolis
added
do-not-merge/hold
and removed
do-not-merge/cla-pending
|
@bonysureliya The usage page still defaults to Month 1st - Today. You can check the preview environment below: |
There was a problem hiding this comment.
@bonysureliya I've added one comment above. This seems to behave similarly as the current state, ses #16474 (comment).
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
| const today = new Date(); | ||
| const prevMonth = new Date(today.getFullYear(), today.getMonth() - 1, today.getDate()); | ||
| const todayStr = today.toISOString().slice(0, 10); | ||
| const prevMonthStr = prevMonth.toISOString().slice(0, 10); |
There was a problem hiding this comment.
If I'm reading this correctly, this change would ignore the the URL hash parameter and would always set it to one month back. That's actually not the desired behaviour, as it prevents deep-linking of the current view in the URL.
Showing the last 1 month, could be the default behaviour when no hash is supplied, however, but the change as it stands does not do that. You likely want to move the handling into the !match case of this if.
There was a problem hiding this comment.
Thanks alot I was trying to find out what was causing the I have done the similar changes
There was a problem hiding this comment.
Review of Date Changing Functionality , @easyCZ Helped where it was catching bug
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@bonysureliya Is this ready for another review? I'd love to get this merged and fix this annoying issue in #16474. Could you also make sure this is up-to-date with the Cc @easyCZ |
|
Yes I will be completing the issue in one or two days. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
from date = previous month date
to date = current date
Related Issue(s)
Fixes #15544
Release Notes
Build Options:
Experimental feature to run the build with GitHub Actions (and not in Werft).
leeway-target=components:all
Run Leeway with
--dont-testPreview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh