[preview] Fix deploy of resources in multiple ns #16924
Conversation
|
started the job as gitpod-build-wv-fix-deploy-gitpod-ns.1 because the annotations in the pull request description changed |
| @@ -617,7 +617,7 @@ rm -f "${INSTALLER_RENDER_PATH}" | |||
| # Wait for objects to be ready | |||
| # ========================= | |||
| for item in deployment.apps/blobserve deployment.apps/content-service deployment.apps/dashboard deployment.apps/ide-metrics deployment.apps/ide-proxy deployment.apps/ide-service deployment.apps/image-builder-mk3 deployment.apps/minio deployment.apps/node-labeler deployment.apps/payment-endpoint deployment.apps/proxy deployment.apps/public-api-server deployment.apps/redis deployment.apps/server deployment.apps/spicedb deployment.apps/usage deployment.apps/ws-manager deployment.apps/ws-manager-bridge deployment.apps/ws-proxy statefulset.apps/messagebus statefulset.apps/mysql statefulset.apps/openvsx-proxy daemonset.apps/agent-smith daemonset.apps/fluent-bit daemonset.apps/registry-facade daemonset.apps/ws-daemon; do | |||
| kubectl --kubeconfig "${PREVIEW_K3S_KUBE_PATH}" --context "${PREVIEW_K3S_KUBE_CONTEXT}" rollout status "${item}" | |||
| kubectl --kubeconfig "${PREVIEW_K3S_KUBE_PATH}" --context "${PREVIEW_K3S_KUBE_CONTEXT}" --namespace "${PREVIEW_NAMESPACE}" rollout status "${item}" | |||
There was a problem hiding this comment.
was seeing not-found errors here, setting the namespace fixed that. Think the namespace gets updated and doesn't point to default at this point?
There was a problem hiding this comment.
💯 same change was also made here, to fix triggering workspace integration tests in werft.
@vulkoingim @mads-hartmann can we trouble you for reviews?
| @@ -604,7 +604,7 @@ export -f diff-apply | |||
| mkdir temp-installer || true | |||
| pushd temp-installer | |||
| # this will split the big yaml produced by the installer, so we can diff individual parts of it and run them in parallel | |||
| yq4 -s '.kind + "_" + .metadata.name' "../${INSTALLER_RENDER_PATH}" | |||
| yq4 -s '.kind + "_" + .metadata.namespace // "" + "_" + .metadata.name' "../${INSTALLER_RENDER_PATH}" | |||
There was a problem hiding this comment.
Pushed a fix so that // "" defaults to an empty string if the namespace field isn't set (e.g. for namespaces 🙃), otherwise those resources would get skipped
|
started the job as gitpod-build-wv-fix-deploy-gitpod-ns.4 because the annotations in the pull request description changed |
|
Install is having trouble: https://github.com/gitpod-io/gitpod/actions/runs/4473073286 |
|
/hold doesn't work for fresh installs, I tested liked so: |
kylos101
force-pushed
the
wv/fix-deploy-gitpod-ns
branch
from
d68a253 to
1f40216
Compare
|
/unhold Limited the default namespace check to the namespace field (or lack there of).. Without this change, the yaml split yaml file names were just kind and namespace, so they were overwriting each other, and Gitpod wasn't being installed. Test: |
|
Question, non-blocking: |
|
started the job as gitpod-build-wv-fix-deploy-gitpod-ns.6 because the annotations in the pull request description changed |
|
started the job as gitpod-build-wv-fix-deploy-gitpod-ns.7 because the annotations in the pull request description changed |
🤦 thanks |
haven't used that option, but think it would have to be |
WVerlaek
force-pushed
the
wv/fix-deploy-gitpod-ns
branch
from
1f40216 to
87633be
Compare
|
Thanks for the review @mads-hartmann , I rebased and it merged the PR even though creating the preview env failed (too many certs issued), is that expected? Does seem to work on main now, created a preview env successfully |
|
@WVerlaek Ah, I think that's probably because we don't currently have the "create preview"-related jobs marked as required - @vulkoingim might have more context around if this is intended or not |
Description
Fixes resources that exist in multiple namespaces under the same name (e.g.
ws-manager-mk2's role) only getting deployed in one namespaceRelated Issue(s)
How to test
Create preview env
Release Notes
Documentation
Build Options:
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish Options
Installer Options
Add desired feature flags to the end of the line above, space separated
Preview Environment Options:
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh