Skip to content

Remove TLS EOF errors from logs #16930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 21, 2023
Merged

Remove TLS EOF errors from logs #16930

merged 1 commit into from
Mar 21, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 21, 2023

Description

Remove noisy log http: TLS handshake error from XXX.XXX.XXX.XXX:XXXXX: EOF due to clients using plain TCP connections instead of TLS. One of the sources for these errors are the load balancer checks.

How to test

  • Port forward ws-proxy TLS port running kubectl port-forward svc/ws-proxy 9090 &
  • Using netcat check we can reach the port nc -zv localhost 9090
  • Check the ws-proxy pod log does not contains lines like http: TLS handshake error from XXX.XXX.XX.XX:XXXX: EOF

Release Notes

NONE

Build Options:

  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish Options
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer Options
  • with-ee-license
  • with-dedicated-emulation
  • with-ws-manager-mk2
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated

Preview Environment Options:

  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh

Signed-off-by: Manuel de Brito Fontes <[email protected]>
@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-error-log.1 because the annotations in the pull request description changed
(with .werft/ from main)

@werft-gitpod-dev-com
Copy link

started the job as gitpod-build-aledbf-error-log.2 because the annotations in the pull request description changed
(with .werft/ from main)

@aledbf aledbf marked this pull request as ready for review March 21, 2023 00:58
@aledbf aledbf requested a review from a team March 21, 2023 00:58
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Mar 21, 2023
@roboquat roboquat merged commit aa61917 into main Mar 21, 2023
@roboquat roboquat deleted the aledbf/error-log branch March 21, 2023 09:23
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/S team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants