[server/fga] centralize lookup of findUserById #18382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenefftinge
force-pushed
the
se/hook-up-migration
branch
from
53b6a2e to
d9c935c
Compare
akosyakov
reviewed
Jul 28, 2023
svenefftinge
force-pushed
the
se/hook-up-migration
branch
from
d9c935c to
6c8712e
Compare
akosyakov
reviewed
Jul 31, 2023
|
|
||
| if (p) { | ||
| if (p.userId) { |
There was a problem hiding this comment.
@svenefftinge I'm not sure why is it alright to remove this case? Because the property is going to be removed?
There was a problem hiding this comment.
it seems it was added for #5128
There was a problem hiding this comment.
Sorry, I should have added a comment here. We have removed personal projects and this was a left over. I will go through the code and see if we can remove the userID from project all together in a separate PR.
|
I still can find calls to userDB.findUserById in gitpod-sever-impl for admin* methods intentional? |
|
|
akosyakov
reviewed
Jul 31, 2023
akosyakov
approved these changes
Jul 31, 2023
|
/unhold |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to use
UserService#findUserByIdas a central point for running the FGA migrations. In that light we need to make sure that our system is not bypassing the userServices (should do that anyway) and directly use theuserDb.This PR replaces the usages of
UserDB#findUserByIDwithUserService#findUserByIdSummary generated by Copilot
🤖 Generated by Copilot at 53b6a2e
This pull request refactors various classes that deal with user-related operations to use the
UserServiceandUserAuthenticationservices instead of theUserDB, to improve the consistency and reliability of the user data and the authorization logic. It also reorders some imports and adds error handling and logging where needed. The affected classes includeAuthenticator,BearerAuth,BitbucketApp,BitbucketServerApp,GithubApp,GitHubEnterpriseApp,GitLabApp,SessionHandler,UserController, andGitpodServerImpl.Related Issue(s)
Fixes EXP-286
How to test
In addition the unit tests I spun up a preview environment to verify that these changes don't break any user flows.
Documentation
Preview status
Gitpod was successfully deployed to your preview environment.
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-testPublish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/previewIf enabled this will create the environment on GCE infra
Valid options are
all,workspace,webapp,ide,jetbrains,vscode,ssh. If enabled,with-previewandwith-large-vmwill be enabled./hold