Skip to content

[user-namespaces] Support FUSE FS shift #3384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 25, 2021
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 8, 2021

Based on https://github.com/gitpod-io/gitpod/commits/cw/enable-fuse-userns with the latest changes in the main branch

fixes #3064

@aledbf aledbf marked this pull request as draft March 10, 2021 18:19
@aledbf aledbf force-pushed the aledbf/enable-fuse-userns branch 11 times, most recently from dfb6e21 to bb13818 Compare March 19, 2021 01:01
@aledbf
Copy link
Member Author

aledbf commented Mar 19, 2021

/werft run

👍 started the job as gitpod-build-aledbf-enable-fuse-userns.40

@aledbf aledbf force-pushed the aledbf/enable-fuse-userns branch 2 times, most recently from 30664d9 to b4c5d5a Compare March 19, 2021 21:09
@aledbf
Copy link
Member Author

aledbf commented Mar 19, 2021

fuse-overlayfs on /tmp/supervisor2858486556 type fuse.fuse-overlayfs (rw,nodev,noatime,user_id=0,group_id=0,default_permissions,allow_other)
sysfs on /tmp/supervisor2858486556/sys type sysfs (ro,nosuid,nodev,noexec,relatime)
tmpfs on /tmp/supervisor2858486556/sys/fs/cgroup type tmpfs (ro,nosuid,nodev,noexec,relatime,mode=755)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/systemd type cgroup (ro,nosuid,nodev,noexec,relatime,xattr,name=systemd)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/blkio type cgroup (ro,nosuid,nodev,noexec,relatime,blkio)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/cpu,cpuacct type cgroup (ro,nosuid,nodev,noexec,relatime,cpu,cpuacct)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/freezer type cgroup (ro,nosuid,nodev,noexec,relatime,freezer)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/memory type cgroup (ro,nosuid,nodev,noexec,relatime,memory)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/net_cls,net_prio type cgroup (ro,nosuid,nodev,noexec,relatime,net_cls,net_prio)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/rdma type cgroup (ro,nosuid,nodev,noexec,relatime,rdma)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/devices type cgroup (ro,nosuid,nodev,noexec,relatime,devices)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/hugetlb type cgroup (ro,nosuid,nodev,noexec,relatime,hugetlb)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/pids type cgroup (ro,nosuid,nodev,noexec,relatime,pids)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/perf_event type cgroup (ro,nosuid,nodev,noexec,relatime,perf_event)
cgroup on /tmp/supervisor2858486556/sys/fs/cgroup/cpuset type cgroup (ro,nosuid,nodev,noexec,relatime,cpuset)
tmpfs on /tmp/supervisor2858486556/sys/firmware type tmpfs (ro,relatime)
tmpfs on /tmp/supervisor2858486556/dev type tmpfs (rw,nosuid,size=65536k,mode=755)
devpts on /tmp/supervisor2858486556/dev/pts type devpts (rw,nosuid,noexec,relatime,gid=5,mode=620,ptmxmode=666)
mqueue on /tmp/supervisor2858486556/dev/mqueue type mqueue (rw,nosuid,nodev,noexec,relatime)
shm on /tmp/supervisor2858486556/dev/shm type tmpfs (rw,nosuid,nodev,noexec,relatime,size=65536k)
/dev/sda1 on /tmp/supervisor2858486556/dev/termination-log type ext4 (rw,relatime)
udev on /tmp/supervisor2858486556/dev/net/tun type devtmpfs (rw,nosuid,relatime,size=15397932k,nr_inodes=3849483,mode=755)
/dev/sdb on /tmp/supervisor2858486556/workspace type ext4 (rw,relatime,discard)
/dev/sda1 on /tmp/supervisor2858486556/etc/hosts type ext4 (rw,relatime)
/dev/sda1 on /tmp/supervisor2858486556/etc/hostname type ext4 (rw,relatime)
/dev/sda1 on /tmp/supervisor2858486556/etc/resolv.conf type ext4 (rw,relatime)
tmpfs on /tmp/supervisor2858486556/tmp type tmpfs (rw,relatime,uid=33333,gid=33333)

@aledbf aledbf marked this pull request as ready for review March 19, 2021 21:42
@aledbf aledbf force-pushed the aledbf/enable-fuse-userns branch from 7c3298f to a1f25f7 Compare March 22, 2021 11:58
@aledbf
Copy link
Member Author

aledbf commented Mar 22, 2021

/werft run

👍 started the job as gitpod-build-aledbf-enable-fuse-userns.48

@aledbf
Copy link
Member Author

aledbf commented Mar 22, 2021

/werft run

👍 started the job as gitpod-build-aledbf-enable-fuse-userns.50

@aledbf aledbf force-pushed the aledbf/enable-fuse-userns branch from dddb617 to 988ea96 Compare March 22, 2021 13:06
@aledbf aledbf changed the title WIP [user-namespaces] Support FUSE FS shift [user-namespaces] Support FUSE FS shift Mar 22, 2021
@aledbf
Copy link
Member Author

aledbf commented Mar 22, 2021

No feature preview (gitpod.io)

Filesystem     1K-blocks      Used Available Use% Mounted on
overlay        406319508 339703972  66599152  84% /
tmpfs              65536         0     65536   0% /dev
tmpfs           32933092         0  32933092   0% /sys/fs/cgroup
/dev/sdb       385996160 264531972 101787004  73% /workspace
/dev/sda1      406319508 339703972  66599152  84% /etc/hosts
shm                65536         0     65536   0% /dev/shm
tmpfs           32933092         0  32933092   0% /proc/acpi
tmpfs           32933092         0  32933092   0% /proc/scsi
tmpfs           32933092         0  32933092   0% /sys/firmware

Current staging (userns enabled by default)

Filesystem     1K-blocks      Used Available Use% Mounted on
fuse-overlayfs 203070420 169629048  33424988  84% /
tmpfs           15411296         0  15411296   0% /sys/fs/cgroup
tmpfs           15411296         0  15411296   0% /sys/firmware
tmpfs              65536         0     65536   0% /dev
shm                65536         0     65536   0% /dev/shm
/dev/sda1      203070420 169629048  33424988  84% /etc/hosts
udev            15397948         0  15397948   0% /dev/net/tun
/dev/sdb       385996160 123369144 242949832  34% /workspace
tmpfs           15411296    296640  15114656   2% /tmp
tmpfs           15411296         0  15411296   0% /proc/acpi
tmpfs              65536         0     65536   0% /proc/keys
tmpfs           15411296         0  15411296   0% /proc/scsi

@csweichel
Copy link
Contributor

csweichel commented Mar 24, 2021

/werft run

👍 started the job as gitpod-build-aledbf-enable-fuse-userns.53

Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised :)

Only thing we'd need to change is the make-shared call (see comment).

@aledbf aledbf force-pushed the aledbf/enable-fuse-userns branch from 988ea96 to b55705d Compare March 24, 2021 11:19
[user-namespaces] Support FUSE FS shift
@aledbf aledbf force-pushed the aledbf/enable-fuse-userns branch from b55705d to 0aa7051 Compare March 24, 2021 11:23
@aledbf aledbf requested a review from csweichel March 24, 2021 11:53
@aledbf
Copy link
Member Author

aledbf commented Mar 24, 2021

@csweichel, please review one more time :)

@aledbf aledbf force-pushed the aledbf/enable-fuse-userns branch 3 times, most recently from ceca391 to 4e03c06 Compare March 24, 2021 17:44
@aledbf aledbf force-pushed the aledbf/enable-fuse-userns branch from 4e03c06 to 34620cd Compare March 24, 2021 17:53
@aledbf
Copy link
Member Author

aledbf commented Mar 24, 2021

@csweichel, please review. I addressed your comments.

Copy link
Contributor

@csweichel csweichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Changes LGTM 🚀

@aledbf aledbf merged commit 9e6635d into main Mar 25, 2021
@aledbf aledbf deleted the aledbf/enable-fuse-userns branch March 25, 2021 11:13
pavan-tri pushed a commit to trilogy-group/gitpod that referenced this pull request Apr 28, 2021
[user-namespaces] Support FUSE FS shift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support FUSE in user-namespaced workspaces
2 participants