Skip to content

[docs][scripts] fix broken README.md weblinks and refactor protoc-generator.sh #4027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 22, 2021
Merged

[docs][scripts] fix broken README.md weblinks and refactor protoc-generator.sh #4027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,24 +33,24 @@ Tightly integrated with GitLab, GitHub, and Bitbucket, Gitpod automatically and

[Learn more 👉](https://www.gitpod.io/features/)

Gitpod is provided as a [managed Saas version](https://gitpod.io) with a free subscription for open-source or a [free self-hosted version](https://www.gitpod.io/self-hosted/). An enterprise license is available [here](https://www.gitpod.io/self-hosted/).
Gitpod is provided as a [managed Saas version](https://gitpod.io) with a free subscription for open-source or a [free self-hosted version](https://www.gitpod.io/self-hosted). An enterprise license is available [here](https://www.gitpod.io/self-hosted).

## Getting Started

You can start using Gitpod with one or more of the following ways:
1. [Use a Prefixed URL](https://www.gitpod.io/docs/context-urls/)
1. [Install Browser Extension](https://www.gitpod.io/docs/browser-extension/)
1. [Enable GitLab Integration](https://www.gitpod.io/docs/gitlab-integration/)
1. [Use a Prefixed URL](https://www.gitpod.io/docs/getting-started/#prefixed-url)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Praise: Nice touch! (For me, the old link still works, but the one you chose works better here 👍)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels weird now, yesterday night few of the links were resulting in 404 pages on the gitpod.io side for me, specifically for the getting-started links in README.md. Now all of them seem to be working 😶 Sorry about it.

1. [Install Browser Extension](https://www.gitpod.io/docs/getting-started#browser-extension)
1. [Enable GitLab Integration](https://www.gitpod.io/docs/getting-started#gitlab-integration)
1. Quick start using an [Example Project](https://www.gitpod.io/docs/getting-started/#example-project) or [OSS Project](https://www.gitpod.io/docs/getting-started/#gitpodified-open-source-project)

## Documentation

All documentation can be found on https://docs.gitpod.io.
For example, see [Introduction](https://www.gitpod.io/docs/) and [Getting Started](https://www.gitpod.io/docs/getting-started/) sections. 📚
All documentation can be found on https://www.gitpod.io/docs.
For example, see [Introduction](https://www.gitpod.io/docs) and [Getting Started](https://www.gitpod.io/docs/getting-started) sections. 📚

## Questions

For questions and support please use the [community forum](http://community.gitpod.io/).
For questions and support please use the [community forum](http://community.gitpod.io).
Join the conversation, and connect with other community members. 💬

You can also follow [`@gitpod`](https://twitter.com/gitpod) for announcements and updates from our team.
Expand Down
6 changes: 5 additions & 1 deletion scripts/protoc-generator.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,11 @@ go_protoc() {

typescript_protoc() {
local ROOT_DIR=$1
local MODULE_DIR=$(pwd)
local MODULE_DIR
# Assigning external program output directly
# after the `local` keyword masks the return value (Could be an error).
# Should be done in a separate line.
MODULE_DIR=$(pwd)

pushd typescript > /dev/null

Expand Down