Improve workspaces empty state

[gtsiolis]

Fix #4455.

BEFORE	AFTER

[gtsiolis]

/werft run

👍 started the job as gitpod-build-gt-improve-workspaces-empty-state.2

[gtsiolis]

/this-is-fine

[roboquat]

@gtsiolis:

In response to this:

/this-is-fine

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[svenefftinge]

I like the graphical ingredient, but it moves everything to the bottom of the page, which is not so great. Can we do something that keeps the empty state centered vertically?

[gtsiolis]

I like the graphical ingredient, but it moves everything to the bottom of the page, which is not so great.

Agree!

Can we do something that keeps the empty state centered vertically?

Yes we can! Removing the list actions (search and filters) when the list is empty can help move everything slightly upwards just like in the empty state of the Projects page, see screenshots in #4455. I've tried this c49bf50 but not sure if code looks good as the build also failed. Alternatively, using an new empty state pattern with a horizontal layout (left: illustration, right: text) could be an option to introduce later or now. WDYT?

[csweichel]

ping @svenefftinge

[svenefftinge]

but not sure if code looks good as the build also failed

The build seem to have failed because there were issues with the deployment. Maybe because of a too long branch name?

[gtsiolis]

Adding meta: blocked label until improvements in #5555 have been merged, see #5555 (comment) and relevant discussion (internal).

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[gtsiolis]

Re-opening as this is still relevant. Will try to pick this up in the next couple of days.

Also, marking as draft for now but feel free to pick this up in the meantime if this seems like an easy fix. 🏀

[roboquat]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from gtsiolis after the PR has been reviewed.

Associated issue: #4455

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• components/dashboard/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.