Skip to content

Revert "[dashboard] Start at most one workspace after prebuild finished" #4909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jankeromnes
Copy link
Contributor

"Shot in the dark" attempt to fix #4908

@roboquat roboquat requested a review from AlexTugarev July 22, 2021 09:59
@jankeromnes jankeromnes marked this pull request as draft July 22, 2021 09:59
@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jankeromnes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AlexTugarev
Copy link
Member

@jankeromnes, I think it's best to sync with @geropl on this.

As far as I understood this was independent of #4875.

@jankeromnes
Copy link
Contributor Author

Might not be the correct fix: #4908 (comment)

@ghuntley
Copy link
Contributor

See #4856 (comment)

@jankeromnes
Copy link
Contributor Author

Closing for now, as the issue stopped reproducing, and we don't know whether this revert actually achieves anything.

@jankeromnes jankeromnes deleted the jx/test-revert branch August 10, 2021 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prebuild logs are no longer being shown
4 participants