Skip to content

[teams] use owner's GitLab account by default #5900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2021
Merged

[teams] use owner's GitLab account by default #5900

merged 1 commit into from
Oct 1, 2021

Conversation

AlexTugarev
Copy link
Member

@AlexTugarev AlexTugarev commented Sep 28, 2021 •
edited
Loading

Description

When creating a new project from gitlab.com one's personal account should be preselected.

Related Issue(s)

Fixes #5331

How to test

Release Notes

NONE

@roboquat roboquat requested a review from geropl September 28, 2021 09:07
@AlexTugarev AlexTugarev force-pushed the at/personal-gl-account branch from c6c0dc4 to e04b973 Compare September 28, 2021 11:46
@AlexTugarev
Copy link
Member Author

@gtsiolis, while implementing this change I realized that this somewhat contradicts the wanted behavior for GitHub accounts where we want to preselect the account which received the most recent update of the app's installation. For instance, if I recently added Gitpod's App to gitbhub.com/myawesomeaccont123, I want to see that one preselected.

a) Should we explicitly diverge the provider behaviors?
b) Or should we stick to a single rule?

I've made a change for a) but it doesn't sound well enough, IMO.

@AlexTugarev AlexTugarev requested review from gtsiolis and removed request for geropl September 28, 2021 12:08
@AlexTugarev AlexTugarev marked this pull request as ready for review September 28, 2021 13:58
@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 28, 2021 •
edited by werft-gitpod-dev-com bot
Loading

Looking at this now! 👀

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Sep 29, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-at-personal-gl-account.4

@AlexTugarev
Copy link
Member Author

AlexTugarev commented Sep 30, 2021 •
edited by werft-gitpod-dev-com bot
Loading

/werft run

👍 started the job as gitpod-build-at-personal-gl-account.5

@AlexTugarev
Copy link
Member Author

@gtsiolis, please have a look

@gtsiolis
Copy link
Contributor

gtsiolis commented Sep 30, 2021 •
edited
Loading

Looking at this now, again! 👀

@gtsiolis gtsiolis added component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. team: webapp Issue belongs to the WebApp team labels Sep 30, 2021
gtsiolis
gtsiolis approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@gtsiolis gtsiolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great, @AlexTugarev! 🖖

I could test this using GitLab, works as expected, and feels right. ✔️

Regarding the comment in #5900 (comment), I'd say let's go with the explicit diverge for the providers and improve later if needed after seeing this in action at large. 🚢

Approving to unblock merging but holding in case this needs a closer look at the code.

/hold

@roboquat roboquat added the lgtm label Sep 30, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: aea62dc3645bc56700c99080f7d5403cb6f685a5

@AlexTugarev
Copy link
Member Author

/hold cancel

Let's solve issues in follow ups

@gtsiolis
Copy link
Contributor

/approve

@gtsiolis
Copy link
Contributor

Ah, @AlexTugarev we need someone from server component owners to also approve[1], right?

@AlexTugarev
Copy link
Member Author

/approve

@roboquat
Copy link
Contributor

roboquat commented Oct 1, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev, gtsiolis

Associated issue: #5331

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 249c1ec into main Oct 1, 2021
@roboquat roboquat deleted the at/personal-gl-account branch October 1, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gtsiolis gtsiolis gtsiolis approved these changes

Assignees

@gtsiolis gtsiolis

Labels
approved component: dashboard feature: teams and projects [DEPRECATED] Please, use feature: organizations or feature: projects labels instead. release-note-none size/S team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default to personal account when importing a project from GitLab
3 participants
@AlexTugarev @gtsiolis @roboquat