-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Dashboard] Beta notice for New Teams and New Projects #6430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@AlexTugarev @gtsiolis |
@@ -308,6 +308,9 @@ export default function NewProject() { | |||
)} | |||
</div> | |||
)} | |||
<p className="text-left w-full mt-12 text-gray-500"> | |||
<strong>Teams & Projects</strong> are currently in Beta. <a href="https://github.com/gitpod-io/gitpod/issues/5095" target="_blank" rel="noopener" className="gp-link">Send feedback</a> or Open a <a href="/workspaces" className="gp-link">New Workspace</a> with an example repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: we should better not pollute tabs using _blank
target, but rather reuse per category. giving them a name like gitpod-feedback
prevents multiple instances if user clicks multiple times on the link. but we can clean up later on
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or Open a
-> or open a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to advertise the example repos here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll change the grammar to say or open a
- thx for the pointer.
The reason for the link to the example repos on the New Project
page, is that when we redirect from the website to /new, this is where new users will land after they log in (instead of going through the another website section with links to the examples first).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JanKoehnlein explained me also why this is a good idea as long as we do not have importing of example projects into your (personal) account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexTugarev I pushed a squashed commit with your suggested gitpod-feedback-issue
target, and the lowercase or open a
grammar fix.
/werft run 👍 started the job as gitpod-build-jldec-beta-tag-in-ui-for-new-teams-6010.17 |
de48811
to
a15cde9
Compare
@@ -308,6 +308,10 @@ export default function NewProject() { | |||
)} | |||
</div> | |||
)} | |||
<p className="text-left w-full mt-12 text-gray-500"> | |||
<strong>Teams & Projects</strong> are currently in Beta.<br/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looked better without the additional line breaks. 🙏🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree - i accidentally pushed an older version - will fix it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed and squashed and pushed new commit.
/lgtm /hold |
LGTM label has been added. Git tree hash: 885c1eb7993c8c6f6db0c76cd338868c60058626
|
540b5ea
to
37f5e1b
Compare
/werft run 👍 started the job as gitpod-build-jldec-beta-tag-in-ui-for-new-teams-6010.21 |
I think this is ready to merge now. |
/hold cancel |
/lgtm |
LGTM label has been added. Git tree hash: c3f1810e89ce00776553ff0828adcad77fc004c3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AlexTugarev Associated issue: #1139 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Adds footers with Beta notice and link to docs on
New Projects
andNew Teams
pages.Also adds link to Workspaces from the
New Projects
page, in order to provide a path for onboarding users to access example repos when we ship gitpod-io/website#1139.Related Issue(s)
Fixes #6010
Release Notes