Skip to content

[Dashboard] Beta notice for New Teams and New Projects #6430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 29, 2021

Conversation

jldec
Copy link
Contributor

@jldec jldec commented Oct 27, 2021

Description

  • Adds footers with Beta notice and link to docs on New Projects and New Teams pages.

  • Also adds link to Workspaces from the New Projects page, in order to provide a path for onboarding users to access example repos when we ship gitpod-io/website#1139.

Screenshot 2021-10-28 at 23 09 29 Screenshot 2021-10-28 at 23 09 00

Related Issue(s)

Fixes #6010

Release Notes

NONE

@jldec
Copy link
Contributor Author

jldec commented Oct 28, 2021

@AlexTugarev @gtsiolis
Since this is my first PR, would you mind checking the styles and html tags please
I wasn't sure about using <p> and the font size, margin etc.

@@ -308,6 +308,9 @@ export default function NewProject() {
)}
</div>
)}
<p className="text-left w-full mt-12 text-gray-500">
<strong>Teams &amp; Projects</strong> are currently in Beta. <a href="https://github.com/gitpod-io/gitpod/issues/5095" target="_blank" rel="noopener" className="gp-link">Send feedback</a> or Open a <a href="/workspaces" className="gp-link">New Workspace</a> with an example repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: we should better not pollute tabs using _blank target, but rather reuse per category. giving them a name like gitpod-feedback prevents multiple instances if user clicks multiple times on the link. but we can clean up later on

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or Open a -> or open a

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to advertise the example repos here?

Copy link

@gptest1 gptest1 Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change the grammar to say or open a - thx for the pointer.

The reason for the link to the example repos on the New Project page, is that when we redirect from the website to /new, this is where new users will land after they log in (instead of going through the another website section with links to the examples first).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JanKoehnlein explained me also why this is a good idea as long as we do not have importing of example projects into your (personal) account.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlexTugarev I pushed a squashed commit with your suggested gitpod-feedback-issue target, and the lowercase or open a grammar fix.

@AlexTugarev
Copy link
Member

AlexTugarev commented Oct 28, 2021

/werft run

👍 started the job as gitpod-build-jldec-beta-tag-in-ui-for-new-teams-6010.17

@jldec jldec force-pushed the jldec/beta-tag-in-ui-for-new-teams-6010 branch from de48811 to a15cde9 Compare October 28, 2021 14:29
@@ -308,6 +308,10 @@ export default function NewProject() {
)}
</div>
)}
<p className="text-left w-full mt-12 text-gray-500">
<strong>Teams &amp; Projects</strong> are currently in Beta.<br/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looked better without the additional line breaks. 🙏🏻

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree - i accidentally pushed an older version - will fix it now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed and squashed and pushed new commit.

@AlexTugarev
Copy link
Member

AlexTugarev commented Oct 28, 2021

/lgtm

/hold
in case you want to remove the line breaks 🙏🏻

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 885c1eb7993c8c6f6db0c76cd338868c60058626

@roboquat roboquat added approved and removed lgtm labels Oct 28, 2021
@jldec jldec force-pushed the jldec/beta-tag-in-ui-for-new-teams-6010 branch from 540b5ea to 37f5e1b Compare October 28, 2021 15:39
@jldec
Copy link
Contributor Author

jldec commented Oct 28, 2021

/werft run

👍 started the job as gitpod-build-jldec-beta-tag-in-ui-for-new-teams-6010.21

@jldec
Copy link
Contributor Author

jldec commented Oct 28, 2021

I think this is ready to merge now.

@AlexTugarev
Copy link
Member

/hold cancel

@AlexTugarev
Copy link
Member

/lgtm

@roboquat roboquat added the lgtm label Oct 29, 2021
@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: c3f1810e89ce00776553ff0828adcad77fc004c3

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexTugarev

Associated issue: #1139

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 619a8e3 into main Oct 29, 2021
@roboquat roboquat deleted the jldec/beta-tag-in-ui-for-new-teams-6010 branch October 29, 2021 08:55
@jldec jldec mentioned this pull request Oct 29, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Beta' tag in UI for new teams and projects
4 participants