Include GitLab subgroups #6546
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| /** | ||
| * Copyright (c) 2021 Gitpod GmbH. All rights reserved. | ||
| * Licensed under the GNU Affero General Public License (AGPL). | ||
| * See License-AGPL.txt in the project root for license information. | ||
| */ | ||
|
|
||
| import * as chai from 'chai'; | ||
| import { suite, test } from 'mocha-typescript'; | ||
| import { RepoURL } from './repo-url'; | ||
|
|
||
| const expect = chai.expect; | ||
|
|
||
| @suite | ||
| export class RepoUrlTest { | ||
|
|
||
| @test public parseRepoUrl() { | ||
| const testUrl = RepoURL.parseRepoUrl("https://gitlab.com/hello-group/my-cool-project.git") | ||
| expect(testUrl).to.deep.equal({ | ||
| host: 'gitlab.com', | ||
| owner: 'hello-group', | ||
| repo: 'my-cool-project' | ||
| }); | ||
| } | ||
|
|
||
| @test public parseSubgroupOneLevel() { | ||
| const testUrl = RepoURL.parseRepoUrl("https://gitlab.com/hello-group/my-subgroup/my-cool-project.git") | ||
| expect(testUrl).to.deep.equal({ | ||
| host: 'gitlab.com', | ||
| owner: 'hello-group/my-subgroup', | ||
| repo: 'my-cool-project' | ||
| }); | ||
| } | ||
|
|
||
| @test public parseSubgroupTwoLevels() { | ||
| const testUrl = RepoURL.parseRepoUrl("https://gitlab.com/hello-group/my-subgroup/my-sub-subgroup/my-cool-project.git") | ||
| expect(testUrl).to.deep.equal({ | ||
| host: 'gitlab.com', | ||
| owner: 'hello-group/my-subgroup/my-sub-subgroup', | ||
| repo: 'my-cool-project' | ||
| }); | ||
| } | ||
|
|
||
| @test public parseSubgroupThreeLevels() { | ||
| const testUrl = RepoURL.parseRepoUrl( | ||
| "https://gitlab.com/hello-group/my-subgroup/my-sub-subgroup/my-sub-sub-subgroup/my-cool-project.git") | ||
| expect(testUrl).to.deep.equal({ | ||
| host: 'gitlab.com', | ||
| owner: 'hello-group/my-subgroup/my-sub-subgroup/my-sub-sub-subgroup', | ||
| repo: 'my-cool-project' | ||
| }); | ||
| } | ||
|
|
||
| @test public parseSubgroupFourLevels() { | ||
| const testUrl = RepoURL.parseRepoUrl( | ||
| "https://gitlab.com/hello-group/my-subgroup/my-sub-subgroup/my-sub-sub-subgroup/my-sub-sub-sub-subgroup/my-cool-project.git") | ||
|
There was a problem hiding this comment. issue(non-blocking): Cross-posting from #5362 (comment) to bring this up again, although sounds ok to leave this out of the scope of this PR, in case we'd like to make plan any action:
There was a problem hiding this comment. I'd love to answer but I'm not sure I know what this question or this context means, even after reading the issue. Maybe something I can ask about in the next team call? Also cc-ing @JanKoehnlein in case he has context. |
||
| expect(testUrl).to.deep.equal({ | ||
| host: 'gitlab.com', | ||
| owner: 'hello-group/my-subgroup/my-sub-subgroup/my-sub-sub-subgroup/my-sub-sub-sub-subgroup', | ||
| repo: 'my-cool-project' | ||
| }); | ||
| } | ||
|
|
||
| } | ||
|
|
||
| module.exports = new RepoUrlTest() | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
praise: Thanks for adding these tests here, @laushinka! 🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to @svenefftinge for the reminder to write more tests :)