-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Support custom CA certificates in Helm #6590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Associated issue: #2984 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
@iQQBot thank you for the PR, but unfortunately, we are in the process to deprecate and replace the helm chart with a go installer https://github.com/gitpod-io/gitpod/tree/main/installer |
I see that, this is a part for #6563 |
No stable version of installer has been released yet, and helm seems to have better control if it is used as a development debug stage @aledbf |
@iQQBot I understand that but merging anything to the chart would be a mistake at this stage. |
OK, Another idea, I can make this a patch file, so that new contributors can apply this patch on their own dev environment and get the quick dev environment, is this OK? @aledbf |
/werft run 👍 started the job as gitpod-build-pd-custom-ca-fork.0 |
just want to have a online image ref to test |
Codecov Report
@@ Coverage Diff @@
## main #6590 +/- ##
===========================================
+ Coverage 19.04% 38.24% +19.19%
===========================================
Files 2 32 +30
Lines 168 8067 +7899
===========================================
+ Hits 32 3085 +3053
- Misses 134 4736 +4602
- Partials 2 246 +244
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I reckon you could achieve the same effect without us adding an additional feature. By mounting a secret using the workspace template, you would just have the CA cert available in the workspace. |
@csweichel The issue is multiple components need to have custom volume and volumeMount parameters. The The approach Bitnami took is that every component has the ability to have a custom mount, and there is a global way to do that for all pods. If this was implemented that way it's possible. The only caveat is the |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@aledbf Is there an update on the installer? |
Description
Adds support to Helm charts for custom CA certificates.
Origin PR is #2984 Thanks to @jgallucci32
A. full-ca-bundle used for normal components, like ws-daemon, server etc.. it contain full chain ca bundle
B. extra-ca-bundle is only contain custom ca bundle, which is used for workspace, use supervisor to inject exist
ca-certificates.crt
Related Issue(s)
Fixes #2615
How to test
Release Notes
Documentation