-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Unshallow repo after workspace is ready #6857
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6857 +/- ##
===========================================
+ Coverage 19.04% 37.15% +18.10%
===========================================
Files 2 19 +17
Lines 168 4578 +4410
===========================================
+ Hits 32 1701 +1669
- Misses 134 2743 +2609
- Partials 2 134 +132
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I thought this idea was rejected when I proposed it in #6464 |
Not sure why it was not included in the original PR but some of us (myself included) have been having issues with the shallow clone so we agreed to unshallow the repo (codespaces also unshallows in the background) |
cmd := runAsGitpodUser(exec.Command("git", "fetch", "--depth", "20")) | ||
var cmd *exec.Cmd | ||
if cfg.isHeadless() { | ||
cmd = runAsGitpodUser(exec.Command("git", "fetch", "--depth", "20")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can do without any fetching on prebuilds.
There has been discussions around pressure on always doing unshallow right after ready. Which made us think about more complex solutions (time-based, only certain cases, etc.). Also my analyzation of codespaces seems to have been wrong, as Jean Pierre found that they indeed just always do an unshallow after start. So, I think we should do the same here now as our current approach has negative effects as mentioned by Jean Pierre. |
443f4bb
to
c15c267
Compare
19771e5
to
ee47366
Compare
/werft run 👍 started the job as gitpod-build-jp-unshallow.7 |
ee47366
to
7ac6115
Compare
/werft run 👍 started the job as gitpod-build-jp-unshallow.9 |
We've just merged a fix for the broken chart. Please rebase which should solve the issue |
7ac6115
to
739aec6
Compare
Ready for review cc @akosyakov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 7750ed822b8b487cb00897db665c9892677683a1
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akosyakov Associated issue: #6796 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Unshallows a repo automatically in the background
Related Issue(s)
Fixes #6796
How to test
git rev-parse --is-shallow-repository
Release Notes
Documentation