Skip to content

feat: Extend workspace timeout #7300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

feat: Extend workspace timeout #7300

wants to merge 7 commits into from

Conversation

ffflorian
Copy link

@ffflorian ffflorian commented Dec 18, 2021

Description

This pull request enables the CLI to manually boost the timeout of the current workspace to 180 minutes.

Related Issue(s)

Fixes #7096

How to test

  1. Be on the Unleashed plan
  2. Create a new workspace
  3. Wait some time until your timeout is about to expire
  4. Run
    gp --extend-timeout
    

Release Notes

You can now manually boost the timeout of the current instance to 180 minutes with the --extend-timeout flag.

Documentation

https://github.com/gitpod-io/website/issues/1386

@akosyakov
Copy link
Member

akosyakov commented Dec 20, 2021

@ffflorian Could you use our PR template please? 🙏

@ffflorian
Copy link
Author

@akosyakov @iQQBot I fixed the mistakes and updated the PR description :)

@roboquat roboquat added the team: webapp Issue belongs to the WebApp team label Dec 22, 2021
if err != nil {
fail(err.Error())
}
_, err = client.SetWorkspaceTimeout(ctx, wsInfo.WorkspaceId, *serverapi.WorkspaceTimeoutDuration180m)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't figure out how to use the type serverapi.WorkspaceTimeoutDuration dereferenced. Could you help me out here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declaration side seems to be wrong. It does not need to be a pointer.

@iQQBot
Copy link
Contributor

iQQBot commented Dec 24, 2021

/werft run

👍 started the job as gitpod-build-feat-extend-timeout-fork.0

@akosyakov
Copy link
Member

@ffflorian Did you manage to figure out how to run/debug it? I don't think you need prev envs for this. You can build it and run against your current workspace.

@JanKoehnlein JanKoehnlein removed the team: webapp Issue belongs to the WebApp team label Jan 5, 2022
@roboquat
Copy link
Contributor

roboquat commented Jan 5, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign filiptronicek after the PR has been reviewed.
You can assign the PR to them by writing /assign @filiptronicek in a comment when ready.

Associated issue: #7096

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@akosyakov
Copy link
Member

@ffflorian is it alright if we will take care of finishing it?

@ffflorian
Copy link
Author

ffflorian commented Jan 7, 2022

@akosyakov Sure!

@stale
Copy link

stale bot commented Jan 17, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Jan 17, 2022
@stale stale bot closed this Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gp-cli] allow to extend timeout
6 participants