-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: Extend workspace timeout #7300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ffflorian Could you use our PR template please? 🙏 |
@akosyakov @iQQBot I fixed the mistakes and updated the PR description :) |
if err != nil { | ||
fail(err.Error()) | ||
} | ||
_, err = client.SetWorkspaceTimeout(ctx, wsInfo.WorkspaceId, *serverapi.WorkspaceTimeoutDuration180m) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't figure out how to use the type serverapi.WorkspaceTimeoutDuration
dereferenced. Could you help me out here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Declaration side seems to be wrong. It does not need to be a pointer.
/werft run 👍 started the job as gitpod-build-feat-extend-timeout-fork.0 |
@ffflorian Did you manage to figure out how to run/debug it? I don't think you need prev envs for this. You can build it and run against your current workspace. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Associated issue: #7096 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ffflorian is it alright if we will take care of finishing it? |
@akosyakov Sure! |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
This pull request enables the CLI to manually boost the timeout of the current workspace to 180 minutes.
Related Issue(s)
Fixes #7096
How to test
Release Notes
Documentation
https://github.com/gitpod-io/website/issues/1386