Skip to content

Download instead of view account statement #7633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Jan 17, 2022

Description

Account statement is downloadable instead of viewed in the browser.

BEFORE NOW
Screenshot 2022-01-17 at 10 26 20
Screenshot 2022-01-17 at 10 25 30

Related Issue(s)

Fixes #7583

How to test

  1. Go to the Admin page
  2. Search for a user
  3. Click on Download Account Statement
  4. See the account statement downloaded locally

Release Notes

Admin users can download the account statement.

Documentation

@roboquat roboquat added release-note team: webapp Issue belongs to the WebApp team size/M labels Jan 17, 2022
@laushinka laushinka force-pushed the laushinka/account-statement-7583 branch from b8b11d9 to a7530e1 Compare January 17, 2022 09:33
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #7633 (a7530e1) into main (94f3b38) will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7633      +/-   ##
==========================================
- Coverage   11.63%   10.38%   -1.26%     
==========================================
  Files          20       18       -2     
  Lines        1160      992     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1022      888     -134     
+ Partials        3        1       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f3b38...a7530e1. Read the comment docs.

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9d29e886b7fb4755491acba3ea41dd6727971192

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #7583

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 020599f into main Jan 17, 2022
@roboquat roboquat deleted the laushinka/account-statement-7583 branch January 17, 2022 09:56
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make View Account Statement more usable
3 participants