Skip to content

[server] Make ws.close() more stable #7635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 17, 2022
Merged

[server] Make ws.close() more stable #7635

merged 3 commits into from
Jan 17, 2022

Conversation

geropl
Copy link
Member

@geropl geropl commented Jan 17, 2022

Description

This:

  • includes an update to ws that makes ws.close more stable
  • ensures we do not hinder ws.emitClose by throwing errors during event handling
  • adds a way to re-emit ws.on('close'', ...) events for websockets stuck in CLOSED

Related Issue(s)

Fixes #7082

How to test

Release Notes

NONE

Documentation

@geropl geropl added type: bug Something isn't working component: server labels Jan 17, 2022
@geropl geropl requested a review from a team January 17, 2022 09:58
@roboquat roboquat added team: webapp Issue belongs to the WebApp team size/M labels Jan 17, 2022
@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #7635 (b6025ef) into main (94f3b38) will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7635      +/-   ##
==========================================
- Coverage   11.63%   10.38%   -1.26%     
==========================================
  Files          20       18       -2     
  Lines        1160      992     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1022      888     -134     
+ Partials        3        1       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.38% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/auth.go
components/local-app/pkg/auth/pkce.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f3b38...b6025ef. Read the comment docs.

@JanKoehnlein
Copy link
Contributor

/lgtm

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 750c3b80c23b602486a79e01c29685dbcc925282

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JanKoehnlein

Associated issue: #7082

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0a2fdf7 into main Jan 17, 2022
@roboquat roboquat deleted the gpl/ws-stable-close branch January 17, 2022 12:17
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component: server deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team type: bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[server] Investigate server event loop lag
3 participants