Skip to content

added 3 new workspace nodepools for preview-environments #7755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Conversation

fullmetalrooster
Copy link
Contributor

Description

This adds new nodepools for workspaces. This PR needs to be applied before this is merged.

Related Issue(s)

Fixes #https://github.com/gitpod-io/ops/issues/800

How to test

Release Notes

None

Documentation

@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #7755 (97f63e4) into main (9a7411f) will decrease coverage by 1.25%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7755      +/-   ##
==========================================
- Coverage   11.54%   10.28%   -1.26%     
==========================================
  Files          20       18       -2     
  Lines        1169     1001     -168     
==========================================
- Hits          135      103      -32     
+ Misses       1031      897     -134     
+ Partials        3        1       -2     
Flag Coverage Δ
components-gitpod-cli-app 10.28% <ø> (ø)
components-local-app-app-darwin-amd64 ?
components-local-app-app-darwin-arm64 ?
components-local-app-app-linux-amd64 ?
components-local-app-app-linux-arm64 ?
components-local-app-app-windows-386 ?
components-local-app-app-windows-amd64 ?
components-local-app-app-windows-arm64 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/local-app/pkg/auth/pkce.go
components/local-app/pkg/auth/auth.go

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a7411f...97f63e4. Read the comment docs.

Copy link
Contributor

@mads-hartmann mads-hartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. Added the hold label so it won't get merged automatically. Just remove it when you're ready to merge.

@roboquat
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0a839972d8e0fa5b4e636bfb22a7d0292d4b58c6

@fullmetalrooster
Copy link
Contributor Author

https://github.com/gitpod-io/ops/pull/801 has been merged.

@fullmetalrooster
Copy link
Contributor Author

/approved

@roboquat
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mads-hartmann

Associated issue: #800

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roboquat roboquat merged commit 0e1109f into main Jan 24, 2022
@roboquat roboquat deleted the wth/add-np branch January 24, 2022 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

3 participants