-
Notifications
You must be signed in to change notification settings - Fork 1.3k
added 3 new workspace nodepools for preview-environments #7755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #7755 +/- ##
==========================================
- Coverage 11.54% 10.28% -1.26%
==========================================
Files 20 18 -2
Lines 1169 1001 -168
==========================================
- Hits 135 103 -32
+ Misses 1031 897 -134
+ Partials 3 1 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM. Added the hold label so it won't get merged automatically. Just remove it when you're ready to merge.
LGTM label has been added. Git tree hash: 0a839972d8e0fa5b4e636bfb22a7d0292d4b58c6
|
https://github.com/gitpod-io/ops/pull/801 has been merged. |
/approved |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: mads-hartmann Associated issue: #800 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This adds new nodepools for workspaces. This PR needs to be applied before this is merged.
Related Issue(s)
Fixes #https://github.com/gitpod-io/ops/issues/800
How to test
Release Notes
Documentation