Improve logging for webhooks from GitHub #8144
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #8144 +/- ##
===========================================
- Coverage 28.17% 11.17% -17.00%
===========================================
Files 41 18 -23
Lines 3478 993 -2485
===========================================
- Hits 980 111 -869
+ Misses 2443 880 -1563
+ Partials 55 2 -53
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
|
/werft run 👍 started the job as gitpod-build-jldec-webhook-logs.1 |
jldec
force-pushed
the
jldec/webhook-logs
branch
2 times, most recently
from
5ffcec2 to
f797dd3
Compare
jldec
force-pushed
the
jldec/webhook-logs
branch
from
f797dd3 to
a48e177
Compare
|
roboquat should not have closed this. |
|
/werft run 👍 started the job as gitpod-build-jldec-webhook-logs.6 |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improve our GitHub webhook handler to log errors instead of only tracing.
Related Issue(s)
Fixes #7938
Release Notes