[bridge] Binding for PreparingUpdateEmulator #8279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexTugarev
reviewed
Feb 17, 2022
| @@ -70,5 +70,6 @@ export const containerModule = new ContainerModule(bind => { | |||
|
|
|||
| bind(IAnalyticsWriter).toDynamicValue(newAnalyticsWriterFromEnv).inSingletonScope(); | |||
|
|
|||
| bind(PreparingUpdateEmulator).toSelf().inRequestScope(); | |||
AlexTugarev
approved these changes
Feb 17, 2022
|
/werft run 👍 started the job as gitpod-build-gpl-cross-cluster-bridge-2.2 |
Codecov Report
@@ Coverage Diff @@
## main #8279 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up for: #8273
Sorry to the reviewer: too many things in parallel 😞
Works now 🎉 (upper tab is EU, lower is US)
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation