WIP: [Installer]: add a render apply command
#8379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrsimonemms
force-pushed
the
sje/installer-apply
branch
from
6b68d5a to
24fe2f2
Compare
Codecov Report
@@ Coverage Diff @@
## main #8379 +/- ##
========================================
- Coverage 8.41% 7.59% -0.83%
========================================
Files 33 31 -2
Lines 2340 2172 -168
========================================
- Hits 197 165 -32
+ Misses 2138 2004 -134
+ Partials 5 3 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This command exists to handle cleanup of unused resources.
For example, if the config goes from in-cluster DB to external, the
rendercommand doesn't delete the old MySQL resources from the cluster. This PR exists provides that functionality.Fundamentally, this packages the files as a Helm folder in a temp folder and then installs it via Helm. By using Helm, we simplify the implementation and benefit from their testing. This does mean that the installation will appear in
helm ls -aA, but I don't see that as being a major issue.How to test
Release Notes
Documentation