[kots]: make the self-hosted cert more explicitly selectable #8633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous "in-cluster" naming still required the config to receive LetsEncrypt variables. This has now been switched to a "select self-signed" or "use a valid cert" flow
Codecov Report
@@ Coverage Diff @@
## main #8633 +/- ##
==========================================
- Coverage 14.87% 11.17% -3.70%
==========================================
Files 52 18 -34
Lines 4963 993 -3970
==========================================
- Hits 738 111 -627
+ Misses 4153 880 -3273
+ Partials 72 2 -70
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Pothulapati
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous "in-cluster" naming still required the config to receive LetsEncrypt variables. This has now been switched to a "select self-signed" or "use a valid cert" flow
IMPORTANT this does nothing to make Gitpod run with a self-signed certificate (#8559). It is still a requirement to have a valid TLS cert. This flow would be used if generating a valid TLS cert and terminating against the load balancer, such as the EKS Guide
How to test
Run in KOTS
Release Notes
Documentation