Skip to content

Show git providers #8645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Show git providers #8645

wants to merge 1 commit into from

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented Mar 7, 2022

Description

[WIP] This shows the list of git providers of a user.

Screenshot 2022-03-07 at 19 43 16

Related Issue(s)

Fixes #8451

How to test

https://lm-git-integ-8451.staging.gitpod-dev.com/admin/users

Release Notes

Shows git providers of a user in the admin user detail.

Documentation

@laushinka
Copy link
Contributor Author

@AlexTugarev The intention of #8451 is to help with debugging and customer support, so that the admin can see what providers and integrations the user has. I'm actually not sure I'm doing the right thing here or looking at the right data. It took a while to understand the different auth information. Probably I also created methods that already exist somewhere but was not obvious to me.

@laushinka laushinka requested review from AlexTugarev and jldec March 7, 2022 18:50
@AlexTugarev
Copy link
Member

I think we already have everything in place for this admin feature. If you look at the Integrations page, you'll find all the details you want to add here.

The idea is to use user.identities which should be loaded already and mix it with auth provider infos. See the rendering of the permissions table as well.

@jldec
Copy link
Contributor

jldec commented Mar 9, 2022

Hi @laushinka , could you make me admin in https://lm-git-integ-8451.staging.gitpod-dev.com/ please
🙏

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 9, 2022

Re-posting from #8272 (comment) for visibility:

💡 tip: You can give give another user, including your user, admin rights with a one-line command, see relevant docs (internal).

Cc @jldec

@laushinka
Copy link
Contributor Author

laushinka commented Mar 9, 2022

@jldec I had a call with Alex today and clarified the direction. The current state will change so what you see now won't be relevant 🙏🏽 I will ping you once it's updated.

<div className="flex w-full mt-6 overflow-scroll">
{authProviders && authProviders.length > 0 &&
<Property name="Git providers">
<div className="overflow-scroll">{authProviders?.join(", ")}</div>
Copy link
Contributor

@gtsiolis gtsiolis Mar 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Don't want to block this and maybe this is no longer relevant based on #8645 (comment) but maybe we could change this to look like this. Happy to discuss this in a separate follow up issue.

Collapsed Expanded
providers-collapsed providers-expadned

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing from in progress, let me know if there's any more design feedback needed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gtsiolis Sorry I dropped the ball here - will ping you once I pick it back up!

@stale
Copy link

stale bot commented Mar 26, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Mar 26, 2022
@gtsiolis
Copy link
Contributor

@laushinka Is this PR still relevant or worth closing instead?

thought: It could be helpful if the direction discussed in #8645 (comment) was also posted somewhere publicy in this PR for visibility even if the points are not described in depth. What do you think? Cc @AlexTugarev

@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Mar 28, 2022
@laushinka
Copy link
Contributor Author

laushinka commented Mar 28, 2022

@laushinka Is this PR still relevant or worth closing instead?

thought: It could be helpful if the direction discussed in #8645 (comment) was also posted somewhere publicy in this PR for visibility even if the points are not described in depth. What do you think? Cc @AlexTugarev

Thanks for the ping, @gtsiolis! I intend to get back to this soon and it's a draft PR so I'm not asking for anyone's review yet, but I will unassign myself from the issue. (Do you know if drafts also show up in the review list?)
Re writing the direction, I should've written it down as you suggested, because now it's just remnants in my brain 🤦🏻‍♀️ I will regather my thoughts once I'm on it again.

@gtsiolis
Copy link
Contributor

gtsiolis commented Mar 28, 2022

Thanks for the ping, @gtsiolis! I intend to get back to this soon and it's a draft PR so I'm not asking for anyone's review yet, but I will unassign myself from the issue.

No worries, @laushinka! You are the owner of this PR, I'll leave you decide how to move this forward. I was only triggerred by the stale bot who marked this a stale in #8645 (comment).

Do you know if drafts also show up in the review list?

Only PRs with review requests show up in the review requests list.

I will regather my thoughts once I'm on it again.

Thanks! 🙏

@jldec
Copy link
Contributor

jldec commented Apr 4, 2022

@laushinka it would be nice if we could finish and ship this - I'd still find it very useful for support.
Could you explain a little more why work on this was stopped?

I also added a small clarification in the issue description, regarding showing the userID and/or email which is specific to each integration.

@laushinka
Copy link
Contributor Author

@laushinka it would be nice if we could finish and ship this - I'd still find it very useful for support. Could you explain a little more why work on this was stopped?

@jldec Apologies, was planning to pick this up and then I ended up working on other things. I can pick this back up.

@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 16, 2022
@stale stale bot closed this Apr 21, 2022
@jldec jldec added meta: never-stale This issue can never become stale and removed meta: stale This issue/PR is stale and will be closed soon labels Apr 22, 2022
@jldec jldec reopened this Apr 22, 2022
@reviewpad reviewpad bot mentioned this pull request Apr 4, 2023
9 tasks
@gtsiolis gtsiolis removed the meta: never-stale This issue can never become stale label Jul 10, 2023
@stale
Copy link

stale bot commented Aug 10, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Aug 10, 2023
@stale stale bot closed this Sep 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress meta: stale This issue/PR is stale and will be closed soon release-note size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show git providers in Admin user detail
5 participants