-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Show git providers #8645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show git providers #8645
Conversation
@AlexTugarev The intention of #8451 is to help with debugging and customer support, so that the admin can see what providers and integrations the user has. I'm actually not sure I'm doing the right thing here or looking at the right data. It took a while to understand the different auth information. Probably I also created methods that already exist somewhere but was not obvious to me. |
I think we already have everything in place for this admin feature. If you look at the Integrations page, you'll find all the details you want to add here. The idea is to use |
Hi @laushinka , could you make me admin in https://lm-git-integ-8451.staging.gitpod-dev.com/ please |
Re-posting from #8272 (comment) for visibility:
Cc @jldec |
@jldec I had a call with Alex today and clarified the direction. The current state will change so what you see now won't be relevant 🙏🏽 I will ping you once it's updated. |
<div className="flex w-full mt-6 overflow-scroll"> | ||
{authProviders && authProviders.length > 0 && | ||
<Property name="Git providers"> | ||
<div className="overflow-scroll">{authProviders?.join(", ")}</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: Don't want to block this and maybe this is no longer relevant based on #8645 (comment) but maybe we could change this to look like this. Happy to discuss this in a separate follow up issue.
Collapsed | Expanded |
---|---|
![]() |
![]() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing from in progress, let me know if there's any more design feedback needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gtsiolis Sorry I dropped the ball here - will ping you once I pick it back up!
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@laushinka Is this PR still relevant or worth closing instead? thought: It could be helpful if the direction discussed in #8645 (comment) was also posted somewhere publicy in this PR for visibility even if the points are not described in depth. What do you think? Cc @AlexTugarev |
Thanks for the ping, @gtsiolis! I intend to get back to this soon and it's a draft PR so I'm not asking for anyone's review yet, but I will unassign myself from the issue. (Do you know if drafts also show up in the review list?) |
No worries, @laushinka! You are the owner of this PR, I'll leave you decide how to move this forward. I was only triggerred by the stale bot who marked this a stale in #8645 (comment).
Only PRs with review requests show up in the review requests list.
Thanks! 🙏 |
@laushinka it would be nice if we could finish and ship this - I'd still find it very useful for support. I also added a small clarification in the issue description, regarding showing the userID and/or email which is specific to each integration. |
@jldec Apologies, was planning to pick this up and then I ended up working on other things. I can pick this back up. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
[WIP] This shows the list of git providers of a user.
Related Issue(s)
Fixes #8451
How to test
https://lm-git-integ-8451.staging.gitpod-dev.com/admin/users
Release Notes
Documentation