[server] Finish spans #8853
Merged
[server] Finish spans #8853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankeromnes
approved these changes
Mar 21, 2022
| @@ -1389,27 +1398,34 @@ export class WorkspaceStarter { | |||
| user: User, | |||
| ): Promise<{ initializer: GitInitializer | CompositeInitializer; disposable: Disposable }> { | |||
| const span = TraceContext.startSpan("createInitializerForCommit", ctx); | |||
There was a problem hiding this comment.
Shouldn't spans have the same name as their method? (If they should, we could probably enforce this with a custom linting rule):
Suggested change
| const span = TraceContext.startSpan("createInitializerForCommit", ctx); | |
| const span = TraceContext.startSpan("createCommitInitializer", ctx); |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Finish dangling spans
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation