Skip to content

Remove console statements introduced in #7715 #8899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2022
Merged

Remove console statements introduced in #7715 #8899

merged 1 commit into from
Mar 21, 2022

Conversation

filiptronicek
Copy link
Member

Description

I discovered that in parts of the dashboard my console is full of a very long array of my repo recommendations, so this PR fixes that by removing all console.log()s introduced in #7715.

How to test

Should have no effect on anything at all :)

Release Notes

NONE

I hope these really are not needed, I assumed they would only be needed in debugging.

cc @jankeromnes

@filiptronicek filiptronicek requested a review from a team March 19, 2022 15:34
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Mar 19, 2022
@filiptronicek filiptronicek self-assigned this Mar 20, 2022
jankeromnes
jankeromnes approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@jankeromnes jankeromnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, yes these would be my debugging logs. No need to keep them active for every Gitpod user. 😅

Good catch, many thanks for fixing!

@roboquat roboquat merged commit 4fa1859 into main Mar 21, 2022
@roboquat roboquat deleted the ft/remove-repo-finder-console-statements-1 branch March 21, 2022 09:08
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jankeromnes jankeromnes jankeromnes approved these changes

Assignees

@filiptronicek filiptronicek

Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/XS team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@filiptronicek @jankeromnes @roboquat