Skip to content

workspacekit: Remove slirp4netns codes where it affects the supervisor. #9214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2022
Merged

workspacekit: Remove slirp4netns codes where it affects the supervisor. #9214

merged 1 commit into from
May 9, 2022

Conversation

utam0k
Copy link
Contributor

@utam0k utam0k commented Apr 11, 2022

Description

This PR is a follow-up PR to #9213
no4 of #8106 (comment)

Related Issue(s)

Relates #8106

How to test

on gitpod
https://to-veths-again4.staging.gitpod-dev.com/workspaces

$ docker run hello-world
$ python -m http.server 5000 # and ensure to be able to access 5000 port from outward

Release Notes

workspacekit: Remove slirp4netns codes where it affects the supervisor.

Documentation

No

@iQQBot iQQBot changed the base branch from main to to/veths-again3 April 11, 2022 06:47
@roboquat roboquat added size/XS and removed size/XXL labels Apr 11, 2022
@utam0k utam0k mentioned this pull request Apr 11, 2022
Closed
@stale
Copy link

stale bot commented Apr 23, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the meta: stale This issue/PR is stale and will be closed soon label Apr 23, 2022
@stale stale bot removed the meta: stale This issue/PR is stale and will be closed soon label Apr 28, 2022
@roboquat roboquat added size/L and removed size/XS labels Apr 28, 2022
Base automatically changed from to/veths-again3 to main April 29, 2022 17:15
@utam0k utam0k force-pushed the to/veths-again4 branch from c1f9d74 to 663e392 Compare May 9, 2022 04:43
@roboquat roboquat added size/XS and removed size/L labels May 9, 2022
@utam0k utam0k marked this pull request as ready for review May 9, 2022 04:47
@utam0k utam0k requested a review from a team May 9, 2022 04:47
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label May 9, 2022
jenting
jenting approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did not test but code LGTM

@jankeromnes
Copy link
Contributor

jankeromnes commented May 9, 2022 •
edited by werft-gitpod-dev-com bot
Loading

Thanks for this PR! 🙏

Looks like Werft build failed and is blocking the merge queue. Unblocking:

/hold

/werft run

👍 started the job as gitpod-build-to-veths-again4.4
(with .werft/ from main)

@sagor999
Copy link
Contributor

sagor999 commented May 9, 2022

/unhold since build is green now.

@sagor999
Copy link
Contributor

sagor999 commented May 9, 2022

/unhold

@roboquat roboquat merged commit a766836 into main May 9, 2022
@roboquat roboquat deleted the to/veths-again4 branch May 9, 2022 19:05
@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iQQBot iQQBot iQQBot approved these changes

@jenting jenting jenting approved these changes

Assignees
No one assigned
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note size/XS team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@utam0k @jankeromnes @sagor999 @iQQBot @jenting @roboquat