Skip to content

[public-api] Add mock implementation of GetWorkspace #9594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2022
Merged

[public-api] Add mock implementation of GetWorkspace #9594

merged 1 commit into from
Apr 28, 2022

Conversation

easyCZ
Copy link
Member

@easyCZ easyCZ commented Apr 27, 2022

Description

  • Mock implementation of get workspace - always returns the same payload but with the WorkspaceID from the request.
  • This is intended to allow us to start initial integration effort and to have some OK responses from the server.
  • Sets up a test to get us into the flow and have something ready with tests.
  • This will (of course) be changed to execute the actual logic.

Related Issue(s)

How to test

  • Unit tests

Release Notes

NONE

Documentation

NONE

@easyCZ easyCZ mentioned this pull request Apr 27, 2022
Closed
40 tasks
Base automatically changed from mp/papi-caddy-grpc to main April 28, 2022 07:15
@roboquat roboquat added size/L and removed size/M labels Apr 28, 2022
@easyCZ easyCZ force-pushed the mp/papi-mock-get-workspace branch from cfa0ca9 to 6d8040d Compare April 28, 2022 07:29
@easyCZ easyCZ marked this pull request as ready for review April 28, 2022 07:29
@easyCZ easyCZ requested a review from a team April 28, 2022 07:29
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label Apr 28, 2022
andrew-farries
andrew-farries approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice first step 👍

@roboquat roboquat merged commit 2ed14b3 into main Apr 28, 2022
@roboquat roboquat deleted the mp/papi-mock-get-workspace branch April 28, 2022 15:51
@roboquat roboquat added deployed: webapp Meta team change is running in production deployed Change is completely running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-farries andrew-farries andrew-farries approved these changes

Assignees
No one assigned
Labels
deployed: webapp Meta team change is running in production deployed Change is completely running in production release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@easyCZ @andrew-farries @roboquat