[server] Remove superfluous config field builtinAuthProvidersConfigured #9612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
approved these changes
Apr 28, 2022
| @@ -18,10 +18,11 @@ import { log, LogrusLogLevel } from "@gitpod/gitpod-protocol/lib/util/logging"; | |||
| import { filePathTelepresenceAware } from "@gitpod/gitpod-protocol/lib/env"; | |||
|
|
|||
| export const Config = Symbol("Config"); | |||
| export type Config = Omit<ConfigSerialized, "hostUrl" | "chargebeeProviderOptionsFile"> & { | |||
There was a problem hiding this comment.
A possible risk with this change across boundaries is that a revert of just server may be broken against Installer config provided.
Normally, when removing config it's first made unused by the consumer (server) and then removed in later releases from the config specified.
There was a problem hiding this comment.
A possible risk with this change across boundaries is that a revert of just server may be broken against Installer config provided.
In theory yes, but we 1) do not validate server config (so won't break if it's passed nonetheless), and 2) it's always overridden here.
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Fixes #
How to test
Release Notes
Documentation