Skip to content

[server] Make account deletion for fault tolerant #9654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2022
Merged

[server] Make account deletion for fault tolerant #9654

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
58552f8
[server] Make account deletion for fault tolerant
geropl Apr 29, 2022
dd2ea93
[server] Fix workspace anonymization
geropl Apr 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 29 additions & 5 deletions components/server/src/user/user-deletion-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,13 +98,37 @@ export class UserDeletionService {
const runningWorkspaces = await this.workspaceDb.findRunningInstancesWithWorkspaces(undefined, user.id);

await Promise.all(
runningWorkspaces.map(async (wsi) => {
runningWorkspaces.map(async (info) => {
const wsi = info.latestInstance;

const req = new StopWorkspaceRequest();
req.setId(wsi.latestInstance.id);
req.setId(wsi.id);
req.setPolicy(StopWorkspacePolicy.NORMALLY);

const manager = await this.workspaceManagerClientProvider.get(wsi.latestInstance.region);
await manager.stopWorkspace({}, req);
try {
const manager = await this.workspaceManagerClientProvider.get(wsi.region);
await manager.stopWorkspace({}, req);
} catch (err) {
log.debug(
{
userId: info.workspace.ownerId,
workspaceId: info.workspace.id,
instanceId: wsi.id,
},
"Unable to stop workspace on account deletion",
err,
);

// We cannot find a workspace manager client for this instances' region, or there is any other error while stopping that workspace properly.
// This might be the case if the workspace cluster which we try to stop an instance on is no longer registered.
// This is bad state, but might happen anyway. Instead of failing, we mark the workspace instance as stopped.
await this.workspaceDb.updateInstancePartial(wsi.id, {
status: {
...wsi.status,
phase: "stopped",
},
});
}
}),
);
}
Expand All @@ -130,7 +154,7 @@ export class UserDeletionService {
const workspaces = await this.workspaceDb.findWorkspacesByUser(userId);

await Promise.all(
workspaces.map((ws) => async () => {
workspaces.map(async (ws) => {
this.anonymizeWorkspace(ws);
await this.workspaceDb.store(ws);
}),
Expand Down