Remove sweeper #9677
Merged
Remove sweeper #9677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mads-hartmann
commented
May 2, 2022
| @@ -83,8 +83,6 @@ export async function deployToPreviewEnvironment(werft: Werft, jobConfig: JobCon | |||
| | yq r - data['.dockerconfigjson'] \ | |||
| | base64 -d)" | base64 -w 0`, { silent: true }).stdout.trim(); | |||
|
|
|||
| const sweeperImage = exec(`tar xfO /tmp/dev.tar.gz ./sweeper.txt`).stdout.trim(); | |||
There was a problem hiding this comment.
Because of this change all jobs the run off main (which is the default due to job protection) are going to fail as this file no longer exists for builds on this branch.
There was a problem hiding this comment.
This can be worked around by running the werft job manually, but instructing it to update the GH status like so
werft run github -aupdateGitHubStatus=gitpod-io/gitpod
This is what I did here: https://werft.gitpod-dev.com/job/gitpod-build-mads-remove-sweeper.11
mads-hartmann
force-pushed
the
mads/remove-sweeper
branch
from
c6c6adf to
225065b
Compare
mads-hartmann
force-pushed
the
mads/remove-sweeper
branch
from
225065b to
8c9c39f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We're no longer relying on Sweeper for cleaning up preview environments. It has been superseded by our Werft cleanup job instead.
This PR removes everything related to Sweeper. Once this is merged we can later do the last bit of cleanup on the ops side of this here https://github.com/gitpod-io/ops/pull/2081
Related Issue(s)
Fixes https://github.com/gitpod-io/ops/issues/2079
How to test
werft run github -a without-vm=true -a with-helm=truewerft run githubRelease Notes
Documentation
N/A