[ws-manager] Explicitly proxy image-builder #9714
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jenting
changed the title
jenting
changed the title
princerachit
reviewed
May 3, 2022
| comparable | ||
| } | ||
|
|
||
| func forwardStream[R ProtoMessage](ctx context.Context, recv func() (R, error), send func(R) error) error { |
|
/hold |
princerachit
approved these changes
May 3, 2022
There was a problem hiding this comment.
Code changes look good to me but I don't see anything related to testing so putting this on hold. Has this been tested @csweichel
|
/hold We've decided to delay shipping this to production this week, therefore please do not remove the hold. |
|
/hold cancel Merging this chance is ok because no-one is using it yet. |
roboquat
added
deployed: workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The prior implementation used a generic gRPC proxy package to make ws-manager proxy to image-builder. This package failed in some edge cases which broke image builds.
In this PR we explicitly proxy image-builder.
Hope is that this is a short-lived workaround and we'll get to move the image build to the workspace side properly soon enough.
Release Notes