Skip to content

[dev] Add werft credential helper #9753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

[dev] Add werft credential helper #9753

merged 1 commit into from
May 4, 2022

Conversation

csweichel
Copy link
Contributor

Description

This PR adds a credential helper for werft so that calls towards werft are authenticated.

How to test

Make calls against werft's CLI with a proper policy in place

Release Notes

NONE

@roboquat roboquat added size/S and removed size/XS labels May 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2022

⚠️ Hey reviewer! BE CAREFUL ⚠️
Review the code before opening in your Gitpod. .gitpod.yml was changed and it might be harmful.

@csweichel csweichel marked this pull request as ready for review May 4, 2022 11:25
@csweichel csweichel requested review from a team May 4, 2022 11:25
@github-actions github-actions bot added team: IDE team: devx team: workspace Issue belongs to the Workspace team labels May 4, 2022
liam-j-bennett
liam-j-bennett approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@liam-j-bennett liam-j-bennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

I'm assuming adding the token won't make requests rejected by the unauthenticated endpoints

@roboquat roboquat merged commit c2ed0f4 into main May 4, 2022
@roboquat roboquat deleted the cw/werft-cred branch May 4, 2022 17:54
@roboquat roboquat added deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production labels May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagor999 sagor999 sagor999 approved these changes

@jeanp413 jeanp413 jeanp413 approved these changes

@liam-j-bennett liam-j-bennett liam-j-bennett approved these changes

Assignees
No one assigned
Labels
deployed: IDE IDE change is running in production deployed: workspace Workspace team change is running in production release-note-none size/S team: devx team: IDE team: workspace Issue belongs to the Workspace team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@csweichel @sagor999 @jeanp413 @liam-j-bennett @roboquat