Skip to content

[public-api] transform getWorkspace #9794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022

Conversation

laushinka
Copy link
Contributor

@laushinka laushinka commented May 5, 2022

Description

Transforms mock getWorkspace to what we serve in the API.

Related Issue(s)

Fixes #9787

How to test

Run go test ./... under /components/public-api-server

Release Notes

NONE

Documentation

@laushinka
Copy link
Contributor Author

@easyCZ I can adjust the response closer to what we actually return IRL. Should it be in this PR?

@easyCZ
Copy link
Member

easyCZ commented May 6, 2022

@laushinka Let's start by populating everything we can in the current response. Let's start with this and go to Workspace to check if it's sufficient. We can always add data but let's start small.

@laushinka laushinka force-pushed the laushinka/transform-getworkspace-9787 branch from 95d9dff to 8f4e8d4 Compare May 6, 2022 09:52
@laushinka laushinka marked this pull request as ready for review May 6, 2022 11:34
@laushinka laushinka requested a review from a team May 6, 2022 11:34
@github-actions github-actions bot added the team: webapp Issue belongs to the WebApp team label May 6, 2022
@laushinka laushinka changed the title [WIP] transform getWorkspace [public-api] transform getWorkspace May 6, 2022
@roboquat roboquat merged commit 202d703 into main May 6, 2022
@roboquat roboquat deleted the laushinka/transform-getworkspace-9787 branch May 6, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none size/M team: webapp Issue belongs to the WebApp team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform getWorkspace response
3 participants