Skip to content

[installer] add snapshot class into PVC config for ws-manager #9806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 6, 2022

Conversation

sagor999
Copy link
Contributor

@sagor999 sagor999 commented May 5, 2022

Description

add snapshot class into PVC config for ws-manager

Related Issue(s)

Part of #9475

How to test

Run installer and verify that it added default snapshot class name ("") to ws-manager configmap

Release Notes

NONE

Documentation

@sagor999 sagor999 requested review from a team May 5, 2022 21:51
@github-actions github-actions bot added team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team and removed size/S labels May 5, 2022
@sagor999 sagor999 force-pushed the pavel/install-snapshots branch from e465fcc to 3dc9518 Compare May 5, 2022 22:01
@roboquat roboquat added the size/S label May 5, 2022
Copy link
Contributor

@jenting jenting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I believe there will have another PR to create a default VolumeSnapshotClass.

@@ -134,13 +134,13 @@
"PVCConfiguration": {
"required": [
"size",
"storage-class"
"storageClass"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️
Note: this address the comment.

@roboquat roboquat merged commit 02a9589 into main May 6, 2022
@roboquat roboquat deleted the pavel/install-snapshots branch May 6, 2022 10:31
@roboquat roboquat added the deployed: workspace Workspace team change is running in production label May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production release-note-none size/S team: delivery Issue belongs to the self-hosted team team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants